Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix validation condition into v1.5 #34938

Closed

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #34932 to be assessed for backporting due to the inclusion of the label 1.5-backport.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@radeksimko
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/terraform/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Target Release

1.8.x

Draft CHANGELOG entry

ENHANCEMENTS

This PR is aimed at fixing the validation condition specified in the style guide document. When using the example from the style guide, these are the errors that are thrown:

Error: Invalid reference in variable validation
on variables.tf line 6, in variable "web_instance_count":
6: condition = var.aws_instance_count > 1
The condition for variable "web_instance_count" can only refer to the variable itself, using var.web_instance_count.

Error: Invalid variable validation condition
on variables.tf line 6, in variable "web_instance_count":
6: condition = var.aws_instance_count > 1
The condition for variable "web_instance_count" must refer to var.web_instance_count in order to test incoming values.


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 3, 2024

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@radeksimko
Copy link
Member

Depends on #34909

@radeksimko radeksimko removed their request for review April 10, 2024 09:00
@radeksimko radeksimko closed this Apr 11, 2024
@radeksimko radeksimko deleted the backport/fix/style-guide/hardly-tight-caribou branch April 11, 2024 15:29
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants