Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(login): use $BROWSER environment variable when set to open browser window #34904

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(login): use $BROWSER environment variable when set to open browser window #34904

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79471e0
feat(login): use /vscode/bin/linux-x64/863d2581ecda6849923a2118d93a08…
michaelbrewer Mar 28, 2024
826904b
fix: just return error if any
michaelbrewer Mar 29, 2024
f1522a9
Merge branch 'hashicorp:main' into feat/browser
michaelbrewer Mar 29, 2024
e3764e4
Merge branch 'hashicorp:main' into feat/browser
michaelbrewer Apr 2, 2024
283e646
Merge branch 'hashicorp:main' into feat/browser
michaelbrewer Apr 4, 2024
9a169f2
Merge branch 'hashicorp:main' into feat/browser
michaelbrewer Apr 12, 2024
eddbb84
Merge branch 'hashicorp:main' into feat/browser
michaelbrewer Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/command/webbrowser/native.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
package webbrowser

import (
"context"
"fmt"
"os"
"os/exec"
"time"

"github.com/pkg/browser"
)

Expand All @@ -17,5 +23,15 @@ func NewNativeLauncher() Launcher {
type nativeLauncher struct{}

func (l nativeLauncher) OpenURL(url string) error {
browserEnv := os.Getenv("BROWSER")
if browserEnv != "" {
browserSh := fmt.Sprintf("%s '%s'", browserEnv, url)
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
cmd := exec.CommandContext(ctx, "sh", "-c", browserSh)
_, err := cmd.CombinedOutput()
return err
}

return browser.OpenURL(url)
}