TypedSDK - update all int struct properties to int64
#25910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
service/load-balancers
service/mssql
catriona-m
approved these changes
May 16, 2024
| @@ -435,7 +436,7 @@ func (r ThreatIntelligenceIndicator) Create() sdk.ResourceFunc { | |||
| props.Pattern = &patternValue | |||
|
|
|||
| if model.Confidence != -1 { | |||
| props.Confidence = utils.Int32(model.Confidence) | |||
| props.Confidence = pointer.To(int32(model.Confidence)) | |||
There was a problem hiding this comment.
Suggested change
| props.Confidence = pointer.To(int32(model.Confidence)) | |
| props.Confidence = pointer.To(int64(model.Confidence)) |
| @@ -561,7 +562,7 @@ func (r ThreatIntelligenceIndicator) Update() sdk.ResourceFunc { | |||
| if model.Confidence == -1 { | |||
| properties.Confidence = nil | |||
| } else { | |||
| properties.Confidence = &model.Confidence | |||
| properties.Confidence = pointer.To(int32(model.Confidence)) | |||
There was a problem hiding this comment.
Suggested change
| properties.Confidence = pointer.To(int32(model.Confidence)) | |
| properties.Confidence = pointer.To(int64(model.Confidence)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This change updates all
intreferences in the Typed resources to beint64to align with the values in the SDKs provided bygo-azure-sdkPR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
TypedSDK- update allintstruct properties toint64