azurerm_key_vault - Allow previously existing key vaults to continue to manage the contact field prior to the v3.93.0 conditional polling change
#25777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if it should attempt to retrieve the 'contact' information from the data plane or not...
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
May 20, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.103.1" to "3.104.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.104.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.104.0
FEATURES:

*
New Data Source: `azurerm_elastic_san`
([#25719](https://github.com/hashicorp/terraform-provider-azurerm/issues/25719))

ENHANCEMENTS:

*
New Resource - `azurerm_key_vault_managed_hardware_security_module_key`
([#25935](https://github.com/hashicorp/terraform-provider-azurerm/issues/25935))
*
Data Source - `azurerm_kubernetes_service_version` - support for the
`default_version` property
([#25953](https://github.com/hashicorp/terraform-provider-azurerm/issues/25953))
*
`network/applicationgateways` - update to use `hashicorp/go-azure-sdk`
([#25844](https://github.com/hashicorp/terraform-provider-azurerm/issues/25844))
*
`dataprotection` - update API version to `2024-04-01`
([#25882](https://github.com/hashicorp/terraform-provider-azurerm/issues/25882))
*
`databasemigration` - update API version to `2021-06-30`
([#25997](https://github.com/hashicorp/terraform-provider-azurerm/issues/25997))
*
`network/ips` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))
*
`network/localnetworkgateway` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))
*
`network/natgateway` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))
*
`network/networksecuritygroup` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))
*
`network/publicips` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))
*
`network/virtualwan` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))
*
`network/vpn` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))
*
`azurerm_databricks_workspace` - support for the
`default_storage_firewall_enabled` property
([#25919](https://github.com/hashicorp/terraform-provider-azurerm/issues/25919))
*
`azurerm_key_vault` - allow previously existing key vaults to continue
to manage the `contact` field prior to the `v3.93.0` conditional polling
change
([#25777](https://github.com/hashicorp/terraform-provider-azurerm/issues/25777))
*
`azurerm_linux_function_app` - support for the PowerShell `7.4`
([#25980](https://github.com/hashicorp/terraform-provider-azurerm/issues/25980))
*
`azurerm_log_analytics_cluster` - support for the value `UserAssigned`
in the `identity.type` property
([#25940](https://github.com/hashicorp/terraform-provider-azurerm/issues/25940))
*
`azurerm_pim_active_role_assignment` - remove hard dependency on the
`roleAssignmentScheduleRequests` API, so that role assignments will not
become unmanageable over time
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))
*
`azurerm_pim_eligible_role_assignment` - remove hard dependency on the
`roleEligibilityScheduleRequests` API, so that role assignments will not
become unmanageable over time
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))
*
`azurerm_windows_function_app` - support for the PowerShell `7.4`
([#25980](https://github.com/hashicorp/terraform-provider-azurerm/issues/25980))

BUG
FIXES:

* `azurerm_container_app_job` - Allow
`event_trigger_config.scale.min_executions` to be `0`
([#25931](https://github.com/hashicorp/terraform-provider-azurerm/issues/25931))
*
`azurerm_container_app_job` - update validation to allow the
`replica_retry_limit` property to be set to `0`
([#25984](https://github.com/hashicorp/terraform-provider-azurerm/issues/25984))
*
`azurerm_data_factory_trigger_custom_event` - one of
`subject_begins_with` and `subject_ends_with` no longer need to be set
([#25932](https://github.com/hashicorp/terraform-provider-azurerm/issues/25932))
*
`azurerm_kubernetes_cluster_node_pool` - prevent race condition by
checking the virtual network status when creating a node pool with a
subnet ID
([#25888](https://github.com/hashicorp/terraform-provider-azurerm/issues/25888))
*
`azurerm_postgresql_flexible_server` - fix for default `storage_tier`
value when `storage_mb` field has been changed
([#25947](https://github.com/hashicorp/terraform-provider-azurerm/issues/25947))
*
`azurerm_pim_active_role_assignment` - resolve a number of potential
crashes
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))
*
`azurerm_pim_eligible_role_assignment` - resolve a number of potential
crashes
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))
*
`azurerm_redis_enterprise_cluster_location_zone_support` - add `Central
India` zones support
([#26000](https://github.com/hashicorp/terraform-provider-azurerm/issues/26000))
*
`azurerm_sentinel_alert_rule_scheduled` - the
`alert_rule_template_version` property is no longer `ForceNew`
([#25688](https://github.com/hashicorp/terraform-provider-azurerm/issues/25688))
*
`azurerm_storage_sync_server_endpoint` - preventing a crashed due to
`initial_upload_policy`
([#25968](https://github.com/hashicorp/terraform-provider-azurerm/issues/25968))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/185/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
The previous fix for the calling the data plane while public network access was disabled in
v3.93.0, did not address that the end user may have connected a private endpoint to the existing key vault and blocked them from managing that resource. This PR fixes that issue by enabling the end user to continue to manage the key vault contacts on pre-existing key vaults only.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_key_vault- allow previously existing key vaults to continue to manage thecontactfield prior to thev3.93.0conditional polling changeThis is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.