New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore azurerm_nginx_configuration resource and data source #25773
base: main
Are you sure you want to change the base?
Conversation
"tags": commonschema.Tags(), | ||
} | ||
|
||
if !features.FourPointOhBeta() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this how features are deprecated in TF? I have not looked at this function but I vaguely remember that this was for breaking changes when the provider gets a 4.0 bumped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I got that from this contributing guide: https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/guide-new-fields-to-resource.md#renaming-and-deprecating-a-property, but could use some direction here if there's a different way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing this 👍
b90c439
to
8c26599
Compare
8c26599
to
10fad15
Compare
10fad15
to
d939f29
Compare
d939f29
to
689cb09
Compare
689cb09
to
b7fe1e9
Compare
Reverts #24276
There are a couple of things here:
With configuration now being inline, the use workflow breaks as 1 and 3 cannot be separated.
To fix this, the change to remove the azurerm_nginx_configuration is reverted, and the field that was added to replace it is deprecated.