Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tier argument to aws_vpc_ipam resource #36504

Merged

Conversation

mmourick
Copy link
Contributor

@mmourick mmourick commented Mar 21, 2024

Description

Adds the tier argument to the aws_vpc_ipam resource.

Relations

Closes #34616.
Relates #35747.

References

Output from Acceptance Testing

make testacc TESTS=TestAccIPAM_tiers PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAM_tiers'  -timeout 360m
=== RUN   TestAccIPAM_tiers
=== PAUSE TestAccIPAM_tiers
=== CONT  TestAccIPAM_tiers
--- PASS: TestAccIPAM_tiers (52.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	56.261s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ipam Issues and PRs that pertain to the ipam service. labels Mar 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2024
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR! A few small requests

internal/service/ec2/ipam_test.go Show resolved Hide resolved
internal/service/ec2/ipam_.go Outdated Show resolved Hide resolved
@drewmullen drewmullen removed the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2024
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read function should include a
d.Set("tier", ipam.Tier)

website/docs/r/vpc_ipam.html.markdown Outdated Show resolved Hide resolved
@drewmullen drewmullen self-requested a review March 22, 2024 12:48
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen
Copy link
Member

Thanks for your contribution @mmourick 👏🏼

@ewbankkit ewbankkit self-assigned this Mar 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 25, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIPAM_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccIPAM_ -timeout 360m
=== RUN   TestAccIPAM_byoipIPv6
    ipam_byoip_test.go:26: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccIPAM_byoipIPv6 (0.00s)
=== RUN   TestAccIPAM_basic
=== PAUSE TestAccIPAM_basic
=== RUN   TestAccIPAM_disappears
=== PAUSE TestAccIPAM_disappears
=== RUN   TestAccIPAM_description
=== PAUSE TestAccIPAM_description
=== RUN   TestAccIPAM_operatingRegions
=== PAUSE TestAccIPAM_operatingRegions
=== RUN   TestAccIPAM_cascade
=== PAUSE TestAccIPAM_cascade
=== RUN   TestAccIPAM_tier
=== PAUSE TestAccIPAM_tier
=== RUN   TestAccIPAM_tags
=== PAUSE TestAccIPAM_tags
=== CONT  TestAccIPAM_basic
=== CONT  TestAccIPAM_tags
--- PASS: TestAccIPAM_basic (48.47s)
=== CONT  TestAccIPAM_description
--- PASS: TestAccIPAM_tags (77.43s)
=== CONT  TestAccIPAM_operatingRegions
--- PASS: TestAccIPAM_description (57.67s)
=== CONT  TestAccIPAM_tier
--- PASS: TestAccIPAM_operatingRegions (109.37s)
=== CONT  TestAccIPAM_disappears
--- PASS: TestAccIPAM_tier (80.92s)
=== CONT  TestAccIPAM_cascade
--- PASS: TestAccIPAM_disappears (41.27s)
--- PASS: TestAccIPAM_cascade (66.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	257.318s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 25, 2024
@ewbankkit
Copy link
Contributor

@mmourick Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5ade1b8 into hashicorp:main Mar 25, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 25, 2024
@mmourick mmourick deleted the f/add-tier-argument-to-vpc-ipam-resource branch March 25, 2024 15:37
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/ipam Issues and PRs that pertain to the ipam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Ipam add free tier option
4 participants