Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow a minimum of 1 worker for a Glue Job #36458

Merged
merged 4 commits into from Mar 19, 2024

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Mar 19, 2024

Description

Lower the minimum of number_of_workers to 1

Relations

Closes #23372

References

Output from Acceptance Testing

make testacc TESTS=TestAccGlueJob_ PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m
=== RUN   TestAccGlueJob_basic
=== PAUSE TestAccGlueJob_basic
=== RUN   TestAccGlueJob_disappears
=== PAUSE TestAccGlueJob_disappears
=== RUN   TestAccGlueJob_basicStreaming
=== PAUSE TestAccGlueJob_basicStreaming
=== RUN   TestAccGlueJob_command
=== PAUSE TestAccGlueJob_command
=== RUN   TestAccGlueJob_defaultArguments
=== PAUSE TestAccGlueJob_defaultArguments
=== RUN   TestAccGlueJob_nonOverridableArguments
=== PAUSE TestAccGlueJob_nonOverridableArguments
=== RUN   TestAccGlueJob_description
=== PAUSE TestAccGlueJob_description
=== RUN   TestAccGlueJob_glueVersion
=== PAUSE TestAccGlueJob_glueVersion
=== RUN   TestAccGlueJob_executionClass
=== PAUSE TestAccGlueJob_executionClass
=== RUN   TestAccGlueJob_executionProperty
=== PAUSE TestAccGlueJob_executionProperty
=== RUN   TestAccGlueJob_maxRetries
=== PAUSE TestAccGlueJob_maxRetries
=== RUN   TestAccGlueJob_notificationProperty
=== PAUSE TestAccGlueJob_notificationProperty
=== RUN   TestAccGlueJob_tags
=== PAUSE TestAccGlueJob_tags
=== RUN   TestAccGlueJob_streamingTimeout
=== PAUSE TestAccGlueJob_streamingTimeout
=== RUN   TestAccGlueJob_timeout
=== PAUSE TestAccGlueJob_timeout
=== RUN   TestAccGlueJob_security
=== PAUSE TestAccGlueJob_security
=== RUN   TestAccGlueJob_workerType
=== PAUSE TestAccGlueJob_workerType
=== RUN   TestAccGlueJob_pythonShell
=== PAUSE TestAccGlueJob_pythonShell
=== RUN   TestAccGlueJob_rayJob
=== PAUSE TestAccGlueJob_rayJob
=== RUN   TestAccGlueJob_maxCapacity
=== PAUSE TestAccGlueJob_maxCapacity
=== CONT  TestAccGlueJob_basic
=== CONT  TestAccGlueJob_maxRetries
=== CONT  TestAccGlueJob_security
=== CONT  TestAccGlueJob_nonOverridableArguments
=== CONT  TestAccGlueJob_executionProperty
=== CONT  TestAccGlueJob_executionClass
=== CONT  TestAccGlueJob_glueVersion
=== CONT  TestAccGlueJob_description
=== CONT  TestAccGlueJob_streamingTimeout
=== CONT  TestAccGlueJob_timeout
=== CONT  TestAccGlueJob_tags
=== CONT  TestAccGlueJob_rayJob
=== CONT  TestAccGlueJob_maxCapacity
=== CONT  TestAccGlueJob_command
=== CONT  TestAccGlueJob_defaultArguments
=== CONT  TestAccGlueJob_basicStreaming
=== CONT  TestAccGlueJob_disappears
=== CONT  TestAccGlueJob_notificationProperty
=== CONT  TestAccGlueJob_pythonShell
=== CONT  TestAccGlueJob_workerType
=== NAME  TestAccGlueJob_basicStreaming
    job_test.go:92: Step 1/2 error: Error running apply: exit status 1

        Error: creating Glue Job (tf-acc-test-4945447631411293439): InvalidInputException: Glue version null is not supported for this region
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "676a9b1b-0069-4536-b50d-834ef1375533"
          },
          Message_: "Glue version null is not supported for this region"
        }

          with aws_glue_job.test,
          on terraform_plugin_test.tf line 43, in resource "aws_glue_job" "test":
          43: resource "aws_glue_job" "test" {

--- FAIL: TestAccGlueJob_basicStreaming (20.52s)
--- PASS: TestAccGlueJob_rayJob (35.85s)
--- PASS: TestAccGlueJob_basic (36.40s)
--- PASS: TestAccGlueJob_security (56.16s)
--- PASS: TestAccGlueJob_executionClass (56.42s)
--- PASS: TestAccGlueJob_command (56.57s)
--- PASS: TestAccGlueJob_streamingTimeout (56.94s)
--- PASS: TestAccGlueJob_timeout (56.94s)
--- PASS: TestAccGlueJob_description (56.97s)
--- PASS: TestAccGlueJob_maxCapacity (57.10s)
--- PASS: TestAccGlueJob_nonOverridableArguments (58.09s)
--- PASS: TestAccGlueJob_notificationProperty (58.21s)
--- PASS: TestAccGlueJob_defaultArguments (58.81s)
--- PASS: TestAccGlueJob_executionProperty (59.42s)
--- PASS: TestAccGlueJob_maxRetries (59.92s)
--- PASS: TestAccGlueJob_disappears (60.32s)
--- PASS: TestAccGlueJob_tags (69.22s)
--- PASS: TestAccGlueJob_glueVersion (70.31s)
--- PASS: TestAccGlueJob_workerType (70.86s)
--- PASS: TestAccGlueJob_pythonShell (86.53s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/glue       90.286s
FAIL
make: *** [testacc] Error 1

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. labels Mar 19, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Mar 19, 2024
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Mar 19, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6ec1be6 into hashicorp:main Mar 19, 2024
28 checks passed
@github-actions github-actions bot added this to the v5.42.0 milestone Mar 19, 2024
@bschaatsbergen bschaatsbergen deleted the f/fix-validate-jobs-glue branch March 19, 2024 22:43
Copy link

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-maintainer Contribution from a trusted external contributor. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Glue job minimum number of workers should be 1
2 participants