Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs-page & glossary page packages #970

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nayres
Copy link
Contributor

@nayres nayres commented Jun 6, 2023

🎟️ Asana Task
πŸ” Preview Link

Description

@hashicorp/react-docs-page was moved out of this repo into an internal mono-repo, and unused elsewhere, deeming it safe to be removed.

Through checking if the package could safely be deleted, @hashicorp/react-glossary-page was the only package that was dependent on @hashicorp/react-docs-page. After checking for repos/ packages dependent on@hashicorp/react-glossary-page, I found that it wasn't being used anywhere, making it also safe to remove from this repo.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: c46fba5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview Jun 6, 2023 9:58pm

@nayres nayres requested a review from a team June 6, 2023 21:58
@zchsh
Copy link
Contributor

zchsh commented Jun 6, 2023

🎏 I think we still use @hashicorp/react-docs-page in hashicorp/dev-portal to render https://docs.hashicorp.com/sentinel. That docs.hashicorp.com site is still in "proxied via one app" mode rather than "monorepo" mode, similar to how other io sites were until recently.

Here's the import location, and an example production page file.

We have a task to somehow deal with Sentinel docs, likely by migrating to the Dev Dot UI, in 🎟 [io-migrations] determine how to handle sentinel, in the future. I'm not sure on priority there from a higher level, but happy to provide any info or help that I can in pushing that work forward πŸ™‡β€β™‚οΈ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants