Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GHA to node 20 #1022

Merged
merged 1 commit into from May 8, 2024
Merged

Update GHA to node 20 #1022

merged 1 commit into from May 8, 2024

Conversation

RubenSandwich
Copy link
Contributor

@RubenSandwich RubenSandwich commented May 8, 2024 •
edited

🎟️ Update GHA to Node 20

Description

Updates all offending GHA steps to Node 20.

@RubenSandwich RubenSandwich self-assigned this May 8, 2024
@vercel Vercel
Copy link

vercel bot commented May 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 3:40pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: dfc6544

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

RubenSandwich
RubenSandwich commented May 8, 2024
View reviewed changes
.nvmrc
@@ -1 +1 @@
v14
v16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are running CI tests on Node 16, so we should also set nvm to at least 16 as well.

@RubenSandwich RubenSandwich requested review from a team and EnMod and removed request for a team May 8, 2024 15:39
EnMod
EnMod reviewed May 8, 2024
View reviewed changes
.github/workflows/ci.yml
Comment on lines 15 to 18
- name: Setup Node.js 16.x
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 16.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these instances of 16.x need to be updated to 20.x as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully we do not, we can still use Node 20 > to build things during a GHA. Just no GHA that uses Node 20 > as it's runner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, important distinction 👍 Thanks!

@RubenSandwich RubenSandwich merged commit c2b653d into main May 8, 2024
7 checks passed
@RubenSandwich RubenSandwich deleted the rn/chore/update-gha-node-20 branch May 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnMod EnMod EnMod approved these changes

Assignees

@RubenSandwich RubenSandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RubenSandwich @EnMod