Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alert banner styling updates #1021

Closed
wants to merge 2 commits into from

Conversation

LeahMarieBush
Copy link

@LeahMarieBush LeahMarieBush commented Apr 18, 2024

🎟️ Asana Task
πŸ” Preview Link


Description

This PR updates the styling of the alert banner. As part of these changes, there is no longer a close button on the alert so that code has been removed.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

changeset-bot bot commented Apr 18, 2024

πŸ¦‹ Changeset detected

Latest commit: 3b73402

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-alert-banner Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 18, 2024 4:18pm

@LeahMarieBush LeahMarieBush added the release:canary Triggers a canary release for commits to this pull request label Apr 18, 2024
@LeahMarieBush LeahMarieBush marked this pull request as ready for review April 19, 2024 15:59
@LeahMarieBush LeahMarieBush requested review from a team and EnMod and removed request for a team April 19, 2024 15:59
@LeahMarieBush
Copy link
Author

Alert banner styling will remain the same for now

@LeahMarieBush LeahMarieBush deleted the leah/feat/alert-banner-styling branch April 19, 2024 16:11
@EnMod EnMod removed their request for review April 19, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant