Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace integrationPage with new fields #1018

Closed
wants to merge 1 commit into from

Conversation

pbortnick
Copy link
Contributor

@pbortnick pbortnick commented Jan 18, 2024

🎟️ Asana Task
πŸ” Preview Link


Description

This PR replaces instances of integrationPage with integrationPageSlug in the react-logo-grid component. This is a result of the migration to the Unified Partner Model for the find-a-partner faceted search project. In Dato, the integrationPage field linked to a, now deprecated, cloudPartnerPage record. Since we only need the slug in relation to the company, a new field, integrationPageSlug, was added to the company model and can be used here.

There are very few use cases of <ReactLogoGrid /> being used in our web properties and none of them make use of the integrationPage prop. It is also on its way to being deprecated itself. So this shouldn't have an effect anywhere.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: 7777557

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview Jan 18, 2024 6:08pm

@pbortnick
Copy link
Contributor Author

Closing: turns out this is not needed

@pbortnick pbortnick closed this Jan 18, 2024
@pbortnick pbortnick deleted the pb.logo-grid/integration-page branch January 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant