Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the modern DOM clipboard API #1006

Merged
merged 7 commits into from Dec 19, 2023

Conversation

RubenSandwich
Copy link
Contributor

@RubenSandwich RubenSandwich commented Nov 30, 2023

🎟️ Asana Task
πŸ” Preview Link

Description

Due to us using the depreciated copy to clipboard API it was failing when used in a highly nested hierarchy. (Developer AI) Not sure exactly why it was causing it to fail, as it always reported success, but it simply wouldn't copy. Updating to the current copy to clipboard API fixes this problem.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

changeset-bot bot commented Nov 30, 2023

πŸ¦‹ Changeset detected

Latest commit: 0977c32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-code-block Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 18, 2023 8:43pm

@RubenSandwich
Copy link
Contributor Author

Should I update the version of this component in package.json?

@dstaley
Copy link
Contributor

dstaley commented Dec 18, 2023

@RubenSandwich nope, everything necessary for the packages workflow looks good!

@RubenSandwich RubenSandwich merged commit ca647a0 into main Dec 19, 2023
7 checks passed
@RubenSandwich RubenSandwich deleted the rn.code-block-modern-clipboard-api branch December 19, 2023 17:20
@hashibot-web hashibot-web mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants