fix: correctly determine if array is empty (#1005)

* fix: correctly determine if array is empty * fix: improve readability with some instead of computing length Co-authored-by: Heat Hamilton <55773810+heatlikeheatwave@users.noreply.github.com> --------- Co-authored-by: Heat Hamilton <55773810+heatlikeheatwave@users.noreply.github.com>
hashicorp · Dec 19, 2023 · 6964d98 · 6964d98 · vercel · Dec 19, 2023
1 parent ccb85e8
commit 6964d98
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/gold-walls-warn.md b/.changeset/gold-walls-warn.md
@@ -0,0 +1,5 @@
+---
+'@hashicorp/react-docs-page': patch
+---
+
+Fix hasIndexPage calculation
diff --git a/packages/docs-page/server/get-paths-from-nav-data.ts b/packages/docs-page/server/get-paths-from-nav-data.ts
@@ -30,7 +30,7 @@ export function getPathsFromNavData(
   const pagePathArrays = getPathArraysFromNodes(navDataResolved)
   // Ensure we include an empty array for the "/" index page path
   // (may be included in nav-data, eg for Terraform, or may not, eg for all other sites)
-  const hasIndexPage = pagePathArrays.filter((p) => p == []).length > 0
+  const hasIndexPage = pagePathArrays.some((p) => p.length === 0)
   if (!hasIndexPage) pagePathArrays.unshift([])
   // Return the array of all page paths
   const paths = pagePathArrays.map((p) => ({ params: { [paramId]: p } }))