Skip to content

Commit

Permalink
fix: mark product as optional (#917)
Browse files Browse the repository at this point in the history
  • Loading branch information
dstaley committed Mar 27, 2023
1 parent 42361b1 commit 3d9aeca
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/six-dingos-pay.md
@@ -0,0 +1,5 @@
---
'@hashicorp/react-alert': patch
---

Mark product as optional
5 changes: 5 additions & 0 deletions .changeset/thirty-pugs-listen.md
@@ -0,0 +1,5 @@
---
'@hashicorp/react-docs-page': patch
---

Remove ts-expect-error
2 changes: 1 addition & 1 deletion packages/alert/index.tsx
Expand Up @@ -70,7 +70,7 @@ Alert.fragmentSpec = { fragment }
export default Alert

interface AlertProps {
product: Products
product?: Products
url: string
tag: string
text: string
Expand Down
1 change: 0 additions & 1 deletion packages/docs-page/components/version-alert/index.tsx
Expand Up @@ -23,7 +23,6 @@ export default function VersionAlert({ tag, text }: VersionAlertProps) {

return (
<div className={s.wrapper}>
{/* @ts-expect-error: explicitly not passing `product` */}
<Alert
url={removeVersionFromPath(router.asPath)}
tag={tag}
Expand Down

1 comment on commit 3d9aeca

@vercel
Copy link

@vercel vercel bot commented on 3d9aeca Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.