Fixing transient AWS errors during EBS builds #1764
Conversation
renat-sabitov
force-pushed
the
fix_amazon_instance_waits
branch
from
e4d499f
to
81bee3e
Compare
|
👍 to this fix. |
|
+1 We're getting hit by this problem as well & would appreciate this fix being merged |
|
Any news on this? @renat-sabitov-sirca Are you using a patched version of packer? Can you confirm that the problem is fixed? |
|
@ColinHebert Yes we are and the problem's completely gone. |
renat-sabitov
changed the title
|
What's left todo to get this change merged into master? |
|
@mitchellh Can we get this in the master branch (and possibly a new version of packer)? This issue prevents boxes from being generated properly and can result in a waste of time/money. |
|
I was about to submit my own PR to fix this problem until I saw this existing one. This bug leaves EC2 instances hanging, so unless users are aware of the problem, they may have packer instances running indefinitely. IMO this should be merged and released with the next packer version. |
|
Can this be merged? Seeing this issue a lot in our environment |
|
+1, really frustrating |
|
👍 keen to see this in a release. |
|
|
|
we're seeing this too. this should be merged. |
|
@mitchellh @rasa @sethvargo @erjohnso |
|
@renat-sabitov-sirca we have not had a chance to triage Packer recently. We will get to it as soon as possible 😄 |
| @@ -63,9 +63,9 @@ func AMIStateRefreshFunc(conn *ec2.EC2, imageId string) StateRefreshFunc { | |||
|
|
|||
| // InstanceStateRefreshFunc returns a StateRefreshFunc that is used to watch | |||
| // an EC2 instance. | |||
| func InstanceStateRefreshFunc(conn *ec2.EC2, i *ec2.Instance) StateRefreshFunc { | |||
| func InstanceStateRefreshFunc(conn *ec2.EC2, instanceId string ) StateRefreshFunc { | |||
There was a problem hiding this comment.
The formatting here looks a bit off - could you please run go vet?
|
Minor style comments, but LGTM otherwise |
renat-sabitov
force-pushed
the
fix_amazon_instance_waits
branch
from
81bee3e
to
11431bd
Compare
|
@sethvargo Ran go vet and go fmt on amazon/ebs and fixed one problem. |
|
@sethvargo Do you have rights on mitchelh/goamz? There is a related patch to it |
|
@sethvargo can this me merged now? |
|
👍 |
Relates to hashicorp#1539 AWS is eventually consistent and instance can be not visibile for some time after creation. This fix eliminates describe-instances call before going to the proper wait loop
renat-sabitov
force-pushed
the
fix_amazon_instance_waits
branch
from
11431bd
to
d046e1c
Compare
|
rebased on the master's HEAD |
|
👍 |
|
Can this please be merged, we really need this fix 👍 |
|
Same here. |
|
👍 We hit this many times per day, so getting this fixed and released would be very helpful. |
|
@sethvargo if this one has been reviewed, it'd be nice to include it in the next release as currently the AWS/EBS aspect of packer is unstable at best :/ |
|
+1. I'd love to see this merged and in a new release. |
|
++ on getting this merged and part of 0.8.0 release or a 0.7.X patch. |
…WS API calls, adapted from from the PR @ hashicorp/packer#1764. Addresses issue #37
|
Could we stop with the +1 / ++ comments? Those add nothing to the discussion and I don't believe will get this in any sooner as much I want this too. That said, @mitchellh and @sethvargo, the last commit to this project was 2 weeks ago. If triaging is backing things up, then that is where you can ask trusted members of the Packer dev community to help out and get involved (provided you give them write access). That is the beauty of open source. 😄 |
|
If there's a preferable medium for conveying interest as a user to the authors, I'd be happy to use it instead of +1 comments. |
|
fixes #2001 |
|
Anything we can do to help get this merged in faster? About half my AWS builds are failing because of this error. |
|
👍 About time this was merged. Probably also fixes #2128 |
|
@mitchellh and @sethvargo can we please get this merged, it's been 5 months since this was first put up |
|
LGTM! Sorry for the delay. |
ghost
locked and limited conversation to collaborators
Relates to #1539
AWS is eventually consistent and instance can be not visibile for
some time after creation. This fix eliminates describe-instances
call before going to the proper wait loop