Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -strict to error if there is a key missing #308

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mongey
Copy link

@Mongey Mongey commented Oct 11, 2019

Currently if you forget to pass in variable you'll be left with <no value> in the template.

This prevents rendering of templates unless all of the variables are set.

[ERROR] levant/command: template: jobTemplate:2:3: executing "jobTemplate" at <.foo>: map has no entry for key "foo"

Not sure of the name -strict 馃槅
馃摑 perhaps this should be the default behaviour

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and strict is as good as any

@angrycub
Copy link
Contributor

angrycub commented Nov 9, 2020

@jrasell I think maybe you are going to have to be the one to smash the merge button on this.

Base automatically changed from master to main March 3, 2021 19:50
@sashayakovtseva
Copy link

sashayakovtseva commented May 5, 2021

@jrasell Waiting for this one to be merged as well :)

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@gautamg795
Copy link

Hi, is there anything blocking the merge of this PR? Looks like tests pass and it's been approved by the maintainer.

@skoppe
Copy link

skoppe commented Mar 5, 2024

Getting this in would be great. Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants