Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault file handing to secret function #1490

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tomwerneruk
Copy link

Proposed fix for #1489 to load file contents when an attribute is prefixed by an @ sign.

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 1, 2021

CLA assistant check
All committers have signed the CLA.

@tomwerneruk tomwerneruk marked this pull request as ready for review July 1, 2021 19:44
@tomwerneruk tomwerneruk requested a review from a team July 1, 2021 19:44
@eikenb eikenb added enhancement hashicat-update-required Changes that need to be ported to hashicat vault Related to the Vault integration labels Jul 1, 2021
@eikenb
Copy link
Contributor

eikenb commented Apr 12, 2022

Hey @tomwerneruk,

Sorry for the long sleep on this issue. I was finally getting around to reviewing and including the community PRs and this one looks good except for a missing test. If you are still interested would you consider adding a test? Thanks.

@angrycub
Copy link
Contributor

I was looking at this and thought it looked interesting, but could you accomplish the same behavior with a template variable, file, and secret?

I'd be worried about keeping the @-reference safe, since some implementations that depend on CT explicitly deny file, but you wouldn't be able to flag out this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hashicat-update-required Changes that need to be ported to hashicat vault Related to the Vault integration waiting-reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants