Add WASM support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved some functions and constants around so common ones are in `ui_common.js`. `ui_js.go` Mostly contains a basic call out to `prompt()` to ask for input. It's not perfect, but it works and is simple.
dekimsey
approved these changes
Nov 20, 2023
| @@ -4,7 +4,7 @@ jobs: | |||
| test: | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.18.x] | |||
| go-version: [1.21.x] | |||
There was a problem hiding this comment.
Just confirming, we are setting go.mod to 1.20, but here we are testing with the newest stable intentionally.
Given it's a library and not a cli, I don't think they are required to match. Just wanted to confirm intent and not a typo.
There was a problem hiding this comment.
Correct, this is intentional. Updating go.mod to >= 1.21.0 means that the library requires that version as a minimum. But, that seems a bit overreaching. So, we keep it back to 1.20 so we aren't forcing users of this library to upgrade.
There was a problem hiding this comment.
(See: https://tip.golang.org/doc/go1.21#tools for example)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some functions and constants around so common ones are in
ui_common.js.ui_js.goMostly contains a basic call out toprompt()to ask for input. It's not perfect, but it works and is simple.