Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update log4j2 to align with hedera repo #274

Merged
merged 8 commits into from
May 9, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented May 8, 2024

Description

This pull request changes the following:

  • Updated log4j2 template to align with latest version on hedera repo
  • Root level changed to "Fatal" level, and Logger for "com.swirlds" changed to "DEBUG" level

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners May 8, 2024 15:43
Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Test Results - Windows

  1 files  ±0   18 suites  ±0   1m 46s ⏱️ +11s
118 tests ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cb5d6d0. ± Comparison against base commit 8db5999.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Test Results - Linux

  1 files  ±0   18 suites  ±0   1m 6s ⏱️ -5s
118 tests ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
143 runs  ±0  143 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cb5d6d0. ± Comparison against base commit 8db5999.

♻️ This comment has been updated with latest results.

jeromy-cannon
jeromy-cannon previously approved these changes May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

E2E Test Results

  1 files   12 suites   22m 32s ⏱️
103 tests 103 ✅ 0 💤 0 ❌
109 runs  109 ✅ 0 💤 0 ❌

Results for commit cb5d6d0.

♻️ This comment has been updated with latest results.

src/core/constants.mjs Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
src/core/logging.mjs Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes May 9, 2024
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.25%. Comparing base (e0b55a7) to head (cb5d6d0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   81.36%   81.25%   -0.11%     
==========================================
  Files          33       33              
  Lines        3772     3772              
  Branches      606      685      +79     
==========================================
- Hits         3069     3065       -4     
- Misses        703      707       +4     
Files Coverage Δ
src/commands/node.mjs 79.61% <66.66%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8db59991 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8db5999) Report Missing Report Missing Report Missing
Head commit (cb5d6d0) 3178 2587 81.40%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#274) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@JeffreyDallas JeffreyDallas merged commit a08c52f into main May 9, 2024
21 of 23 checks passed
@JeffreyDallas JeffreyDallas deleted the 095-D-change-log4j2debug-mode branch May 9, 2024 21:25
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants