fix: revert to sleep and remove jest.runAllTicks from e2e test #255
+36
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
E2E Test Results 1 files ± 0 11 suites ±0 22m 23s ⏱️ - 30m 29s Results for commit 90672ac. ± Comparison against base commit a8ed482. This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 77.72% 81.34% +3.61%
==========================================
Files 33 33
Lines 3601 3768 +167
Branches 676 685 +9
==========================================
+ Hits 2799 3065 +266
+ Misses 802 703 -99
... and 3 files with indirect coverage changes |
JeffreyDallas
previously approved these changes
May 3, 2024
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
JeffreyDallas
approved these changes
May 3, 2024
swirlds-automation
added a commit
that referenced
this pull request
May 16, 2024
## [0.25.0](v0.24.0...v0.25.0) (2024-05-16) ### Features * ability to deploy different software package to a subset of nodes ([#232](#232)) ([5e95030](5e95030)) * add `solo node add` subcommand ([#234](#234)) ([8cc3802](8cc3802)) ### Bug Fixes * enhance profile manager to take mirror node component overrides to increase pipeline stability ([#289](#289)) ([c89a042](c89a042)) * increase wait time for when recycling an haproxy pod for a node ([#292](#292)) ([cb5a1c6](cb5a1c6)) * jsdoc could not recognizing Promise<[*]> ([#275](#275)) ([9a9c00c](9a9c00c)) * revert to sleep and remove jest.runAllTicks from e2e test ([#255](#255)) ([a7cf6bf](a7cf6bf)) * use latest FST chart and a single consensus node during mirror-node e2e test ([#264](#264)) ([5a5a02f](5a5a02f))
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues