New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simplify stop port forward function #240
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
E2E Test Results 1 files ±0 11 suites ±0 20m 20s ⏱️ + 2m 41s For more details on these failures, see this check. Results for commit e5160bd. ± Comparison against base commit b1c70e8. This pull request removes 18 and adds 19 tests. Note that renamed tests count towards both.
|
Closing it as I'm not working on it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
async
andawait new Promise....
close
event will be emitted when the port is closed (I know we've found it to be not behaving as it says although doc says theclose
event will be emitted: https://nodejs.org/api/net.html#serverclosecallback).Related Issues