Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify stop port forward function #240

Closed
wants to merge 1 commit into from

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Apr 19, 2024

Description

This pull request changes the following:

  • remove unnecessary async and await new Promise....
  • remove the port open check as the close event will be emitted when the port is closed (I know we've found it to be not behaving as it says although doc says the close event will be emitted: https://nodejs.org/api/net.html#serverclosecallback).

Related Issues

  • Closes #

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   17 suites  ±0   1m 13s ⏱️ -3s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e5160bd. ± Comparison against base commit b1c70e8.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   17 suites  ±0   1m 27s ⏱️ -1s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e5160bd. ± Comparison against base commit b1c70e8.

Copy link
Contributor

E2E Test Results

 1 files  ±0  11 suites  ±0   20m 20s ⏱️ + 2m 41s
92 tests +1  87 ✅  -  3  0 💤 ±0  5 ❌ +4 
84 runs   - 8  80 ✅  - 11  0 💤 ±0  4 ❌ +3 

For more details on these failures, see this check.

Results for commit e5160bd. ± Comparison against base commit b1c70e8.

This pull request removes 18 and adds 19 tests. Note that renamed tests count towards both.
AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment ‑ AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment
AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy ‑ AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy
AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command ‑ AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command
AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command ‑ AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command
AccountCommand account create/update command should be able to get account-1 ‑ AccountCommand account create/update command should be able to get account-1
AccountCommand account create/update command should be able to get account-2 ‑ AccountCommand account create/update command should be able to get account-2
AccountCommand account create/update command should create account with ecdsa private key and set alias ‑ AccountCommand account create/update command should create account with ecdsa private key and set alias
AccountCommand account create/update command should create account with no options ‑ AccountCommand account create/update command should create account with no options
AccountCommand account create/update command should create account with private key and hbar amount options ‑ AccountCommand account create/update command should create account with private key and hbar amount options
AccountCommand account create/update command should update account-1 ‑ AccountCommand account create/update command should update account-1
…
 Test execution failure: could be caused by test hooks like 'afterAll'. ‑  Test execution failure: could be caused by test hooks like 'afterAll'.
[afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment ‑ [afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment
[afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy ‑ [afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy
[afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command ‑ [afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command
[afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command ‑ [afterAll - ERROR]: AccountCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command
[afterAll - ERROR]: AccountCommand account create/update command should be able to get account-1 ‑ [afterAll - ERROR]: AccountCommand account create/update command should be able to get account-1
[afterAll - ERROR]: AccountCommand account create/update command should be able to get account-2 ‑ [afterAll - ERROR]: AccountCommand account create/update command should be able to get account-2
[afterAll - ERROR]: AccountCommand account create/update command should create account with ecdsa private key and set alias ‑ [afterAll - ERROR]: AccountCommand account create/update command should create account with ecdsa private key and set alias
[afterAll - ERROR]: AccountCommand account create/update command should create account with no options ‑ [afterAll - ERROR]: AccountCommand account create/update command should create account with no options
[afterAll - ERROR]: AccountCommand account create/update command should create account with private key and hbar amount options ‑ [afterAll - ERROR]: AccountCommand account create/update command should create account with private key and hbar amount options
…

@leninmehedy
Copy link
Member Author

Closing it as I'm not working on it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant