Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: no need to test k8 copy functionality with large file #174

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Mar 21, 2024

This helps to avoid stability in tests

Description

This pull request changes the following:

  • test: no need to test k8 copy functionality with large build.zip file

This is because copyTo and copyFrom is a bit buggy for large file: #57. Currently it is making our tests unstable as build.hedera.com URL is often slow and DDoS measure blocks our curl HEAD requests.

We are currently fetching the build.zip file directly inside the container, so we really don't need to copy a large file to/from a container.

Related Issues

  • Closes #

@leninmehedy leninmehedy requested a review from a team as a code owner March 21, 2024 02:55
This helps to avoid stability in tests

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link
Contributor

Unit Test Results

  1 files   16 suites   1m 11s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 7731a99.

Copy link
Contributor

E2E Test Results

53 tests  ±0   53 ✅ ±0   5m 50s ⏱️ +4s
 7 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7731a99. ± Comparison against base commit 1d3dcf4.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1d3dcf4) 2564 1786 69.66%
Head commit (7731a99) 2567 (+3) 1789 (+3) 69.69% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#174) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (1d3dcf4) to head (7731a99).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files          32       32           
  Lines        3068     3068           
  Branches      542      542           
=======================================
  Hits         2121     2121           
  Misses        947      947           

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit feba5f9 into main Mar 21, 2024
19 checks passed
@jeromy-cannon jeromy-cannon deleted the fix-e2e-test branch March 21, 2024 08:48
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants