Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick: remove gas cost check (#13031) #13078

Merged
merged 1 commit into from
May 6, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented May 6, 2024

Description:

Cherry-pick of #13031

Related issue(s):

Closes #13030

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
(cherry picked from commit 1c18387)
@netopyr netopyr added this to the v0.50 milestone May 6, 2024
@netopyr netopyr self-assigned this May 6, 2024
@netopyr netopyr requested review from a team as code owners May 6, 2024 15:27
Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 18s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit c45d0e7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  20s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit c45d0e7.

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Token) Results

228 tests   227 ✅  17m 58s ⏱️
 16 suites    1 💤
 16 files      0 ❌

Results for commit c45d0e7.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @netopyr

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  38m 54s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit c45d0e7.

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Misc) Results

457 tests   447 ✅  39m 8s ⏱️
 76 suites   10 💤
 77 files      0 ❌
  1 errors

For more details on these parsing errors, see this check.

Results for commit c45d0e7.

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 43s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit c45d0e7.

Copy link

github-actions bot commented May 6, 2024

Node: HAPI Test (Smart Contract) Results

587 tests   587 ✅  1h 11m 13s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit c45d0e7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 6, 2024

Node: Unit Test Results

  2 267 files  ±0    2 267 suites  ±0   2h 9m 24s ⏱️ - 1h 44m 30s
112 333 tests ±0  112 266 ✅ ±0  67 💤 ±0  0 ❌ ±0 
120 796 runs  ±0  120 729 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit c45d0e7. ± Comparison against base commit 161bb5d.

This pull request removes 3988 and adds 3752 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@51441073
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@a6bd3315
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@1044714b
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@2da9f7ba
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@25402994
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c2bc7a6d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6a2ae026
…

♻️ This comment has been updated with latest results.

@netopyr netopyr merged commit a73ebaf into develop May 6, 2024
50 of 52 checks passed
@netopyr netopyr deleted the 13030-remove-gas-cost-check-cherry-picks branch May 6, 2024 19:14
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove check if gas cost are less than maximum transaction fee
2 participants