Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid catastrophic failure for too large transactions #13029

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix: Avoid catastrophic failure for too large transactions #13029

merged 2 commits into from Apr 29, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Apr 27, 2024

Description:

This PR excludes the check if a message is too large from the catch-all branch.

Related issue(s):

Fixes #13004

@netopyr
Too large transactions should not trigger possibly catastrophic failure
44da3e4 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr added this to the v0.49 milestone Apr 27, 2024
@netopyr netopyr self-assigned this Apr 27, 2024
@netopyr netopyr requested a review from a team as a code owner April 27, 2024 22:19
@netopyr netopyr requested a review from rbair23 April 27, 2024 22:19
@netopyr netopyr changed the title Too large transactions should not trigger possibly catastrophic failure fix: Too large transactions should not trigger possibly catastrophic failure Apr 27, 2024
@netopyr netopyr changed the title fix: Too large transactions should not trigger possibly catastrophic failure fix: Avoid catastrophic failure for too large transactions Apr 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  6m 45s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 7s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Token) Results

215 tests   214 ✔️  20m 20s ⏱️
  16 suites      1 💤
  16 files        0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Crypto) Results

220 tests   220 ✔️  23m 25s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

Neeharika-Sompalli
Neeharika-Sompalli previously approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @netopyr

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Misc) Results

437 tests   427 ✔️  36m 44s ⏱️
  75 suites    10 💤
  75 files        0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  53m 51s ⏱️
  3 suites    0 💤
  3 files      0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

506 tests   503 ✔️  1h 7m 44s ⏱️
  55 suites      3 💤
  55 files        0 ❌

Results for commit 8346440.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

Node: Unit Test Results

    2 266 files  ±0      2 266 suites  ±0   4h 3m 3s ⏱️ + 41m 52s
112 207 tests ±0  112 152 ✔️ ±0  55 💤 ±0  0 ❌ ±0 
120 669 runs  ±0  120 614 ✔️ ±0  55 💤 ±0  0 ❌ ±0 

Results for commit 8346440. ± Comparison against base commit d668e78.

♻️ This comment has been updated with latest results.

@netopyr
Proper handling of long transactions
8346440 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @netopyr

@netopyr netopyr merged commit 8ef29c4 into release/0.49 Apr 29, 2024
44 of 45 checks passed
@netopyr netopyr deleted the 13004-fix-large-tx-handling branch April 29, 2024 14:41
netopyr added a commit that referenced this pull request May 6, 2024
@netopyr
fix: Avoid catastrophic failure for too large transactions (#13029)
6d52de0 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
(cherry picked from commit 8ef29c4)
@netopyr netopyr mentioned this pull request May 6, 2024
Merged
netopyr added a commit that referenced this pull request May 6, 2024
@netopyr
fix: Cherry-pick: Avoid catastrophic failure for too large transactio…
b47753b 
…ns (#13029) (#13079)
@MiroslavGatsanoga MiroslavGatsanoga mentioned this pull request May 9, 2024
Open
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
@netopyr @stoyanov-st
fix: Cherry-pick: Avoid catastrophic failure for too large transactio…
a647886 
…ns (#13029) (#13079)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@netopyr netopyr

Labels
None yet
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@netopyr @Neeharika-Sompalli