Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reconnect): introduce ReconnectMapStats interface #13027

Merged
merged 3 commits into from May 6, 2024

Conversation

anthony-swirldslabs
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs commented Apr 26, 2024

Description:
Introducing an interface to help gather reconnect-related statistics for maps per a proposal at #12412 (comment)

It is out of scope of this particular PR to implement this interface, or start using it.

Related issue(s):

Contributes to #12412
Fixes #13099

Notes for reviewer:
gr assemble passes.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
jasperpotts
jasperpotts previously approved these changes Apr 26, 2024
imalygin
imalygin previously approved these changes Apr 26, 2024
Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  6m 5s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  21s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Token) Results

235 tests   234 ✅  20m 11s ⏱️
 17 suites    1 💤
 17 files      0 ❌

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Misc) Results

457 tests   447 ✅  41m 4s ⏱️
 76 suites   10 💤
 77 files      0 ❌
  1 errors

For more details on these parsing errors, see this check.

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 35s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: Unit Test Results

  2 267 files  ± 0    2 267 suites  ±0   3h 2m 0s ⏱️ + 25m 45s
112 337 tests +10  112 270 ✅ +10  67 💤 ±0  0 ❌ ±0 
120 800 runs  +10  120 733 ✅ +10  67 💤 ±0  0 ❌ ±0 

Results for commit f6a0d6e. ± Comparison against base commit 530c449.

This pull request removes 4005 and adds 3778 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.contract.impl.test.infra.IterableStorageManagerTest ‑ multipleInsertsUseLatestHeadPointer()
com.hedera.node.app.service.contract.impl.test.infra.IterableStorageManagerTest ‑ slotStillInsertedEvenWithMissingPointer()
com.hedera.node.app.service.contract.impl.test.infra.IterableStorageManagerTest ‑ stillRemovesSlotEvenIfNextSlotIsMissing()
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d0b9c265
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@35f11c31
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f8dfed50
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d348eb04
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 41s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

Node: HAPI Test (Smart Contract) Results

588 tests   588 ✅  1h 16m 52s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit f6a0d6e.

♻️ This comment has been updated with latest results.

Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
@anthony-swirldslabs anthony-swirldslabs merged commit ed42123 into develop May 6, 2024
41 of 43 checks passed
@anthony-swirldslabs anthony-swirldslabs deleted the issue-12412-1 branch May 6, 2024 23:37
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize set of metrics, their names, and whether to report them in logs or real metrics
4 participants