-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor and simplify HIP-540 implementation and tests #13012
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a6f2a14
Refactor HIP-540
tinker-michaelj 1eb982d
Add query validations
tinker-michaelj 42dfa9e
Remove redundant tests
tinker-michaelj c3d0278
Resolve merge conflicts
tinker-michaelj 949a038
Add javadoc
tinker-michaelj 69c2895
Allow parallel scenario execution by salting registry names
tinker-michaelj f63144f
spotless
tinker-michaelj d360060
Wording
tinker-michaelj 4629ad2
Cleanup
tinker-michaelj 9858421
fix unit test
tinker-michaelj e50fe29
Prioritize TOKEN_IS_IMMUTABLE when token has neither role nor admin key
tinker-michaelj 429ee9c
Merge remote-tracking branch 'origin/develop' into refactor-hip540
tinker-michaelj 091cf33
Permit updating metadata with just admin key
tinker-michaelj 15b03eb
Merge branch 'hip540-full-implementation' into refactor-hip540
Neeharika-Sompalli b89672d
some docs
Neeharika-Sompalli b6dc987
add testName
Neeharika-Sompalli File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
TOKEN_KEYS
andNON_ADMIN_TOKEN_KEYS
can stay protected