Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove legacy event serialization #12999

Merged
merged 8 commits into from Apr 30, 2024
Merged

chore: remove legacy event serialization #12999

merged 8 commits into from Apr 30, 2024

Conversation

lpetrovic05
Copy link
Member

closes #12996

@lpetrovic05
12996 start, removed old versions and options
5cedb70 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
got rid of unhashed data from GE
1ded6a2 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
removed unhashed data
3380b76 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spot
c7e74fc 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 self-assigned this Apr 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 27s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  26s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Token) Results

228 tests   227 ✅  18m 1s ⏱️
 16 suites    1 💤
 16 files      0 ❌

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Misc) Results

457 tests   446 ✅  45m 12s ⏱️
 76 suites   10 💤
 77 files      1 ❌
  1 errors

For more details on these parsing errors and failures, see this check.

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 45s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 14s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@lpetrovic05 lpetrovic05 added this to the v0.50 milestone Apr 25, 2024
@lpetrovic05 lpetrovic05 marked this pull request as ready for review April 25, 2024 12:57
@lpetrovic05 lpetrovic05 requested review from a team as code owners April 25, 2024 12:57
@lpetrovic05
some javadoc
955e4c8 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

579 tests   578 ✅  1h 8m 1s ⏱️
 62 suites    0 💤
 62 files      1 ❌

For more details on these failures, see this check.

Results for commit 2a1a00c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited

Node: Unit Test Results

  2 267 files  ±0    2 267 suites  ±0   2h 31m 22s ⏱️ + 23m 14s
112 315 tests ±0  112 249 ✅ ±0  66 💤 ±0  0 ❌ ±0 
120 778 runs  ±0  120 712 ✅ ±0  66 💤 ±0  0 ❌ ±0 

Results for commit 2a1a00c. ± Comparison against base commit cae5399.

This pull request removes 3992 and adds 3758 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=11140,hostnameExternal=185.191.203.175,portExternalIpv4=34266,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@2c825b0d,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@28e93df7,memo=tjOqLdxS4o],
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f9d7590
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@eb13bc29
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6744652c
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@769d98fc
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4b2d76c7
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@95941030
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@48dc8a6
…

♻️ This comment has been updated with latest results.

anthony-swirldslabs
anthony-swirldslabs previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform Data changes look good to me.

platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/GossipEvent.java Show resolved Hide resolved
@lpetrovic05
fixes
2a1a00c 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 merged commit 917faaa into develop Apr 30, 2024
41 of 47 checks passed
@lpetrovic05 lpetrovic05 deleted the 12996-D-remove-legacy-serialization branch April 30, 2024 11:17
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
@lpetrovic05 @stoyanov-st
chore: remove legacy event serialization (#12999)
f3e66d3 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alittley alittley alittley approved these changes

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs left review comments

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@imalygin imalygin Awaiting requested review from imalygin imalygin is a code owner automatically assigned from hashgraph/platform-data

@mxtartaglia-sl mxtartaglia-sl Awaiting requested review from mxtartaglia-sl

Assignees

@lpetrovic05 lpetrovic05

Labels
None yet
Projects
None yet
Milestone
v0.50
Development

Successfully merging this pull request may close these issues.

Remove legacy serialization
4 participants
@lpetrovic05 @alittley @edward-swirldslabs @anthony-swirldslabs