feat: Write tests for burn operations #12726 #12998

stefan-stefanooov · 2024-04-25T10:40:23Z

Write E2E suites for HSCS operations affected by the security model
Token Burn
-->

Related issue(s):
#12726
Fixes #
#12726

github-actions · 2024-04-25T15:01:41Z

Node: HAPI Test (Restart) Results

2 tests 2 ✅ 8m 45s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T15:04:33Z

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 ✅ 8m 57s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T15:15:18Z

Node: HAPI Test (Token) Results

235 tests 233 ✅ 20m 43s ⏱️
17 suites 2 💤
17 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T15:36:51Z

Node: HAPI Test (Misc) Results

464 tests 454 ✅ 41m 50s ⏱️
77 suites 10 💤
77 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T15:37:51Z

Node: HAPI Test (Crypto) Results

335 tests 335 ✅ 39m 48s ⏱️
25 suites 0 💤
25 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T15:50:35Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✅ 53m 50s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T16:02:36Z

Node: HAPI Test (Smart Contract) Results

592 tests 592 ✅ 1h 13m 40s ⏱️
63 suites 0 💤
63 files 0 ❌

Results for commit 9b21b83.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T16:19:52Z

Node: Unit Test Results

2 282 files + 2 2 282 suites +2 2h 35m 15s ⏱️ + 22m 36s
118 827 tests +25 118 760 ✅ +25 67 💤 ±0 0 ❌ ±0
127 315 runs +28 127 248 ✅ +28 67 💤 ±0 0 ❌ ±0

Results for commit 9b21b83. ± Comparison against base commit 0d82f26.

This pull request removes 4009 and adds 3797 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.hapi.utils.ethereum.EthTxDataTest ‑ [1] LEGACY_ETHEREUM
com.hedera.node.app.hapi.utils.ethereum.EthTxDataTest ‑ [2] EIP2930
com.hedera.node.app.hapi.utils.ethereum.EthTxDataTest ‑ [3] EIP1559
com.hedera.node.app.service.evm.contracts.execution.HederaEvmTxProcessorTest ‑ assertSuccessExecution050()
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@3de7aa69
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4a78977
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@487a613a
…

♻️ This comment has been updated with latest results.

petreze

In ContractKeysHTSV1SecurityModelSuite we have burnTokenWithFullPrefixAndPartialPrefixKeys() test that is not updated for v2. Is it on purpose?

stefan-stefanooov · 2024-05-07T09:08:16Z

In ContractKeysHTSV1SecurityModelSuite we have burnTokenWithFullPrefixAndPartialPrefixKeys() test that is not updated for v2. Is it on purpose?

Hey, @petreze
I think it is.... the new name is V2SecurityBurnTokenWithFullPrefixAndPartialPrefixKeys.
Am I missing something ?

petreze

LGTM

.../com/hedera/services/bdd/suites/contract/precompile/ContractBurnHTSV2SecurityModelSuite.java

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>

petreze

LGTM

mustafauzunn

LGTM

kimbor

lgtm!

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stefan-stefanooov linked an issue Apr 25, 2024 that may be closed by this pull request

Write tests for burn operations #12726

Closed

stefan-stefanooov self-assigned this Apr 25, 2024

stefan-stefanooov added Test Development Test Development Limechain Work planned for the LimeChain team labels Apr 25, 2024

stefan-stefanooov added this to the v0.46 milestone Apr 25, 2024

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch from 140aa5a to 89db5fe Compare April 25, 2024 14:27

stefan-stefanooov requested review from fchitakova and petreze April 25, 2024 14:36

stefan-stefanooov marked this pull request as ready for review April 25, 2024 14:36

stefan-stefanooov requested review from a team as code owners April 25, 2024 14:36

stefan-stefanooov requested review from jasperpotts, povolev15 and quiet-node April 25, 2024 14:36

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch from 89db5fe to e082225 Compare April 25, 2024 14:39

fchitakova previously approved these changes Apr 26, 2024

View reviewed changes

stefan-stefanooov dismissed fchitakova’s stale review via b84bc91 April 26, 2024 09:40

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch 4 times, most recently from 2349dd3 to 9717316 Compare April 26, 2024 10:20

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch from 9717316 to ffaa9d8 Compare May 2, 2024 06:34

stefan-stefanooov requested a review from fchitakova May 2, 2024 06:34

fchitakova previously approved these changes May 7, 2024

View reviewed changes

petreze reviewed May 7, 2024

View reviewed changes

stefan-stefanooov requested a review from petreze May 7, 2024 09:08

petreze previously approved these changes May 7, 2024

View reviewed changes

mustafauzunn reviewed May 9, 2024

View reviewed changes

.../com/hedera/services/bdd/suites/contract/precompile/ContractBurnHTSV2SecurityModelSuite.java Outdated Show resolved Hide resolved

feat: Write tests for burn operations #12726

2a5c574

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>

stefan-stefanooov dismissed stale reviews from petreze and fchitakova via 2a5c574 May 9, 2024 14:19

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch 2 times, most recently from 2a5c574 to 9296ec0 Compare May 9, 2024 14:19

stefan-stefanooov requested review from mustafauzunn, petreze and fchitakova May 9, 2024 14:19

petreze previously approved these changes May 10, 2024

View reviewed changes

tests fix

14147a4

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>

stefan-stefanooov dismissed petreze’s stale review via 14147a4 May 10, 2024 15:11

stefan-stefanooov force-pushed the 12726-write-tests-for-burn-operations branch from 9296ec0 to 14147a4 Compare May 10, 2024 15:11

stefan-stefanooov requested a review from petreze May 10, 2024 15:14

stefan-stefanooov added 2 commits May 13, 2024 11:11

Refactor to defaultHapiSpec

22a75af

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>

Spotless

9b21b83

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>

petreze approved these changes May 13, 2024

View reviewed changes

mustafauzunn approved these changes May 13, 2024

View reviewed changes

kimbor approved these changes May 13, 2024

View reviewed changes

stefan-stefanooov merged commit 989abba into develop May 14, 2024
44 of 45 checks passed

stefan-stefanooov deleted the 12726-write-tests-for-burn-operations branch May 14, 2024 07:11

stoyanov-st pushed a commit that referenced this pull request May 15, 2024

feat: Write tests for burn operations #12726 (#12998)

efd0b73

Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Write tests for burn operations #12726 #12998

feat: Write tests for burn operations #12726 #12998

stefan-stefanooov commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

petreze left a comment

stefan-stefanooov commented May 7, 2024

petreze left a comment

petreze left a comment

mustafauzunn left a comment

kimbor left a comment

feat: Write tests for burn operations #12726 #12998

feat: Write tests for burn operations #12726 #12998

Conversation

stefan-stefanooov commented Apr 25, 2024 • edited

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Restart) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Apr 25, 2024 • edited

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Apr 25, 2024 • edited

Node: Unit Test Results

petreze left a comment

Choose a reason for hiding this comment

stefan-stefanooov commented May 7, 2024

petreze left a comment

Choose a reason for hiding this comment

petreze left a comment

Choose a reason for hiding this comment

mustafauzunn left a comment

Choose a reason for hiding this comment

kimbor left a comment

Choose a reason for hiding this comment

stefan-stefanooov commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited

github-actions bot commented Apr 25, 2024 •

edited