Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rewrite grpc's "possibly CATASTROPHIC failure" which actually isn't possibly catastrophic, so it is appropriately less scary #13004

Closed
david-bakin-sl opened this issue Apr 25, 2024 · 1 comment · Fixed by #13079
Assignees
Milestone

Comments

@david-bakin-sl
Copy link
Member

If we get a gRPC message or something that's too large (I guess larger than we've configured gRPC for) it throws a RuntimeException with a really scary message which then shows up in our logs and frightens innocent developers, like me.

image

I'm given to understand that it isn't actually possibly catastrophic at all, nor even an error. It's just a warning. (Or so I've been told.)

It would be nice to catch that exception and rewrite it to be more temperate.

@netopyr
Copy link
Contributor

netopyr commented Apr 25, 2024

@david-bakin-sl Thanks for reporting the issue. Can you please attach the whole stack trace? Otherwise, it will be hard to catch the Exception. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants