Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add some comments about the toSolidityAddress function #2220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Mar 25, 2024

Description:
toSolidityAddress function can be misleading; see this StackOverflow issue for details.

This PR adds some comments to make the usage of that function clearer.

Related issue(s):

N/A

Notes for reviewer:

N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com>
@Neurone Neurone changed the title Add some comments about the toSolidityAddress function docs: Add some comments about the toSolidityAddress function Mar 25, 2024
@Neurone Neurone changed the title docs: Add some comments about the toSolidityAddress function docs: add some comments about the toSolidityAddress function Mar 25, 2024
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (5467a47) to head (4c75bbc).

❗ Current head 4c75bbc differs from pull request most recent head db36ceb. Consider uploading reports for the commit db36ceb to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2220   +/-   ##
========================================
  Coverage    84.48%   84.49%           
========================================
  Files          305      305           
  Lines        76285    76287    +2     
========================================
+ Hits         64448    64457    +9     
+ Misses       11837    11830    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants