feat(HIPs-646/657/765): Added implementations for metadata fields #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
14 tasks
rwalworth
reviewed
Mar 22, 2024
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
rwalworth
previously approved these changes
Apr 24, 2024
src/sdk/tests/integration/TokenUpdateTransactionIntegrationTests.cc
Outdated
Show resolved
Hide resolved
src/sdk/tests/integration/TokenUpdateTransactionIntegrationTests.cc
Outdated
Show resolved
Hide resolved
src/sdk/tests/integration/TokenUpdateTransactionIntegrationTests.cc
Outdated
Show resolved
Hide resolved
src/sdk/tests/integration/TokenUpdateTransactionIntegrationTests.cc
Outdated
Show resolved
Hide resolved
src/sdk/tests/integration/TokenUpdateTransactionIntegrationTests.cc
Outdated
Show resolved
Hide resolved
petreze
previously approved these changes
Apr 24, 2024
…ts.cc Co-authored-by: Rob Walworth <110835868+rwalworth@users.noreply.github.com> Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…ts.cc Co-authored-by: Rob Walworth <110835868+rwalworth@users.noreply.github.com> Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…ts.cc Co-authored-by: Rob Walworth <110835868+rwalworth@users.noreply.github.com> Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…ts.cc Co-authored-by: Rob Walworth <110835868+rwalworth@users.noreply.github.com> Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…ts.cc Co-authored-by: Rob Walworth <110835868+rwalworth@users.noreply.github.com> Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
agadzhalov
approved these changes
Apr 26, 2024
gsstoykov
deleted the
00443-add-hip-657-mutable-metadata-fields-for-dynamic-nfts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces
metadataandmetadataKeyfields for token related functionalities described in HIPs-646/657/765Related issue(s):
#445
#674
Fixes #445 #674 #443
Notes for reviewer:
Still not tested as the corresponding functionality in
local-nodeis not yet set up. The related HIPs are closely tied in their implementations and trigger changes in common files so I am creating one PR for them all.Checklist