HIP-646/657/765: Implement token metadata acceptance tests #8166

jascks · 2024-04-23T21:37:52Z

Description:

Acceptance tests and token/mirror client updates to invoke the new HAPI and MAPI functionality recently implemented. Test fungible and non-fungible metadata capabilities as well as that "dynamic" NFTs.

Related issue(s):

Fixes #7765

Notes for reviewer:

This PR is still relying on a beta version of com.hedera.hashgraph:sdk (2.32.0-beta.1). Keeping an eye out for a GA version of 2.32.x. Cannot really merge this PR until that becomes available and things a retested.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

codecov · 2024-04-23T21:42:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (13b6840) to head (f9bc648).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #8166   +/-   ##
=========================================
  Coverage     92.30%   92.30%           
  Complexity     7290     7290           
=========================================
  Files           899      899           
  Lines         29363    29364    +1     
  Branches       3583     3583           
=========================================
+ Hits          27104    27105    +1     
  Misses         1439     1439           
  Partials        820      820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…cceptance-tests

…eviewnet. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

…cceptance-tests

…given statement management added last commit. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

…cceptance-tests

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java

jascks · 2024-04-26T16:12:42Z

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java

    private final TokenClient tokenClient;
    private final AccountClient accountClient;
    private final MirrorNodeClient mirrorClient;

-    private final Map<TokenId, List<Long>> tokenSerialNumbers = new HashMap<>();
+    private final Map<TokenId, List<IndividualNftInfo>> tokenNftInfoMap = new HashMap<>();


State per NFT is now serial number and metadata last set.

should name the class just NftInfo

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/TokenClient.java

xin-hedera · 2024-04-26T18:47:11Z

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java

    private final TokenClient tokenClient;
    private final AccountClient accountClient;
    private final MirrorNodeClient mirrorClient;

-    private final Map<TokenId, List<Long>> tokenSerialNumbers = new HashMap<>();
+    private final Map<TokenId, List<IndividualNftInfo>> tokenNftInfoMap = new HashMap<>();


should name the class just NftInfo

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java

hedera-mirror-test/src/test/resources/features/token/token.feature

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

…ater update using ED25519. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/TokenClient.java

xin-hedera

LGTM

…cceptance-tests. Resolve NFT allowance conflicts. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks · 2024-05-06T18:07:46Z

.github/workflows/gradle.yml

@@ -2,14 +2,14 @@ name: "Gradle"
 on:
  pull_request:
    branches:
-      - 'main'
-      - 'release/**'
+      - "main"


No changes made by me in workflows. Spotless...

jascks · 2024-05-06T18:08:09Z

docs/database/README.md

@@ -272,8 +272,8 @@ Following are the prerequisites and steps for migrating V1 data to V2.
   [migration.config](/hedera-mirror-importer/src/main/resources/db/scripts/v2/migration.config).
 4. Get the correct version of [flyway](https://flywaydb.org/documentation/usage/commandline/) based on your OS and
   update it in the `FLYWAY_URL` field in the `migration.config` file. The default is set to the linux version.
-5. Stop the [Importer](/docs/importer/README.md) process. 
-6. Run the [migration.sh](/hedera-mirror-importer/src/main/resources/db/scripts/v2/migration.sh) script. Due to the time it will take to complete the migration, 
+5. Stop the [Importer](/docs/importer/README.md) process.


No changes here. Spotless...

…cceptance-tests

steven-sheehy

LGTM

steven-sheehy · 2024-05-07T23:11:51Z

Will need another merge from main

…cceptance-tests Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

sonarcloud · 2024-05-08T01:25:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

xin-hedera

LGTM

Clean manual merge with main of changes from old feature branch.

8bedb8f

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks self-assigned this Apr 24, 2024

jascks added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Apr 24, 2024

jascks added 7 commits April 24, 2024 08:27

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

d4a0e2e

…cceptance-tests

Improved state management for NFT serials. Full NFT flow passes on pr…

7e5b63d

…eviewnet. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

416c8e3

…cceptance-tests

Removed up specification of metadata bytes in steps. Cleaner overall …

8d000e1

…given statement management added last commit. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Added metadata and key steps to fungible token flow.

8dcd470

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

df9322d

…cceptance-tests

Verify token without metdata or key are valid. NPE fix.

daffcc3

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks commented Apr 26, 2024

View reviewed changes

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java Show resolved Hide resolved

jascks commented Apr 26, 2024

View reviewed changes

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java Show resolved Hide resolved

jascks commented Apr 26, 2024

View reviewed changes

Minor cleanup.

f4bf6a0

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks marked this pull request as ready for review April 26, 2024 16:34

jascks requested a review from a team April 26, 2024 16:35

jascks mentioned this pull request Apr 26, 2024

NFT allowances acceptance tests #8177

Merged

2 tasks

xin-hedera requested changes Apr 26, 2024

View reviewed changes

xin-hedera added this to the 0.104.0 milestone Apr 26, 2024

jascks added 3 commits April 27, 2024 09:40

Address PR comments.

12d701d

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Address PR comment.

f83100d

Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

Update iInital token create with metadata key using ECDSA key, with l…

da2b42f

…ater update using ED25519. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

xin-hedera reviewed Apr 29, 2024

View reviewed changes

hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/TokenClient.java Show resolved Hide resolved

xin-hedera previously approved these changes Apr 29, 2024

View reviewed changes

steven-sheehy modified the milestones: 0.104.0, 0.105.0 May 3, 2024

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

d6248f5

…cceptance-tests. Resolve NFT allowance conflicts. Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks dismissed xin-hedera’s stale review via d6248f5 May 6, 2024 18:06

jascks commented May 6, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

6d32381

…cceptance-tests

steven-sheehy previously approved these changes May 7, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into 7765-token-metadata-a…

f9bc648

…cceptance-tests Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>

jascks dismissed steven-sheehy’s stale review via f9bc648 May 8, 2024 01:19

xin-hedera approved these changes May 8, 2024

View reviewed changes

steven-sheehy modified the milestones: 0.105.0, 0.106.0 May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HIP-646/657/765: Implement token metadata acceptance tests #8166

HIP-646/657/765: Implement token metadata acceptance tests #8166

jascks commented Apr 23, 2024 •

edited

codecov bot commented Apr 23, 2024 •

edited

jascks Apr 26, 2024

xin-hedera Apr 26, 2024

jascks Apr 27, 2024

xin-hedera Apr 26, 2024

xin-hedera left a comment

jascks May 6, 2024

jascks May 6, 2024

steven-sheehy left a comment

steven-sheehy commented May 7, 2024

sonarcloud bot commented May 8, 2024

xin-hedera left a comment

HIP-646/657/765: Implement token metadata acceptance tests #8166

Are you sure you want to change the base?

HIP-646/657/765: Implement token metadata acceptance tests #8166

Conversation

jascks commented Apr 23, 2024 • edited

codecov bot commented Apr 23, 2024 • edited

Codecov Report

jascks Apr 26, 2024

Choose a reason for hiding this comment

xin-hedera Apr 26, 2024

Choose a reason for hiding this comment

jascks Apr 27, 2024

Choose a reason for hiding this comment

xin-hedera Apr 26, 2024

Choose a reason for hiding this comment

xin-hedera left a comment

Choose a reason for hiding this comment

jascks May 6, 2024

Choose a reason for hiding this comment

jascks May 6, 2024

Choose a reason for hiding this comment

steven-sheehy left a comment

Choose a reason for hiding this comment

steven-sheehy commented May 7, 2024

sonarcloud bot commented May 8, 2024

Quality Gate passed

xin-hedera left a comment

Choose a reason for hiding this comment

jascks commented Apr 23, 2024 •

edited

codecov bot commented Apr 23, 2024 •

edited