Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIP-904 Frictionless Airdrops design #8127

Merged
merged 12 commits into from May 9, 2024

Conversation

edwin-greene
Copy link
Contributor

@edwin-greene edwin-greene commented Apr 18, 2024

Description:

Add the design doc for HIP-904 Friction-less Airdrops

Related issue(s):

Fixes #8082

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
@edwin-greene edwin-greene added documentation Type: Improvements or additions to documentation enhancement Type: New feature design labels Apr 18, 2024
@edwin-greene edwin-greene added this to the 0.104.0 milestone Apr 18, 2024
@edwin-greene edwin-greene self-assigned this Apr 18, 2024
@edwin-greene edwin-greene linked an issue Apr 18, 2024 that may be closed by this pull request
@edwin-greene edwin-greene requested a review from a team April 18, 2024 18:26
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (2b6f271) to head (5a454cb).
Report is 85 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8127      +/-   ##
============================================
+ Coverage     92.24%   92.44%   +0.20%     
+ Complexity     7282     7181     -101     
============================================
  Files           901      881      -20     
  Lines         29284    29089     -195     
  Branches       3572     3560      -12     
============================================
- Hits          27012    26891     -121     
+ Misses         1451     1383      -68     
+ Partials        821      815       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edwin-greene edwin-greene marked this pull request as draft April 18, 2024 19:40
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
@edwin-greene edwin-greene marked this pull request as ready for review April 18, 2024 21:57
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
@steven-sheehy steven-sheehy modified the milestones: 0.104.0, 0.105.0 May 3, 2024
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Some suggestions for consideration and clarity.

docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Show resolved Hide resolved
docs/design/frictionless-airdrops.md Outdated Show resolved Hide resolved
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy requested a review from Nana-EC May 8, 2024 20:26
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@edwin-greene edwin-greene merged commit cca4ae2 into main May 9, 2024
29 checks passed
@edwin-greene edwin-greene deleted the 8082-hip-904-frictionless-airdrops-design branch May 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design documentation Type: Improvements or additions to documentation enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-904: Frictionless Airdrops Design
5 participants