Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in equivalence tests for direct calls #7812

Draft
wants to merge 6 commits into
base: 7193-add-in-equivalence-tests-for-system-accounts
Choose a base branch
from

Conversation

yiliev0
Copy link
Contributor

@yiliev0 yiliev0 commented Feb 26, 2024

Description: This PR is still in progress. There are a few assertions that are waiting on bugs to be fixed, so this can be finalised.

Related issue(s):

Fixes #7193

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Yordan Iliev <yordan.iliev@limechain.tech>
@yiliev0 yiliev0 marked this pull request as draft February 26, 2024 13:02
@yiliev0 yiliev0 changed the base branch from main to 7193-add-in-equivalence-tests-for-system-accounts February 26, 2024 13:03
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (8a400d1) to head (28b4025).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             7193-add-in-equivalence-tests-for-system-accounts    #7812      +/-   ##
=======================================================================================
+ Coverage                                                92.27%   92.42%   +0.15%     
+ Complexity                                                6918     4590    -2328     
=======================================================================================
  Files                                                      864      638     -226     
  Lines                                                    28332    20603    -7729     
  Branches                                                  3363     2539     -824     
=======================================================================================
- Hits                                                     26142    19043    -7099     
+ Misses                                                    1426     1034     -392     
+ Partials                                                   764      526     -238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustafauzunn mustafauzunn added the limechain Work planned for the LimeChain team label Feb 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (8a400d1) to head (28b4025).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##             7193-add-in-equivalence-tests-for-system-accounts    #7812      +/-   ##
=======================================================================================
+ Coverage                                                92.27%   92.31%   +0.04%     
- Complexity                                                6918     6998      +80     
=======================================================================================
  Files                                                      864      868       +4     
  Lines                                                    28332    28521     +189     
  Branches                                                  3363     3398      +35     
=======================================================================================
+ Hits                                                     26142    26329     +187     
- Misses                                                    1426     1427       +1     
- Partials                                                   764      765       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch from 8a400d1 to a10e213 Compare March 8, 2024 15:02
@yiliev0 yiliev0 added the test Test infrastructure, automated tests required, etc label Mar 12, 2024
@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch 4 times, most recently from e700c89 to b2618d6 Compare March 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
limechain Work planned for the LimeChain team test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in-equivalence tests
4 participants