Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

07193 Add in equivalence tests for system accounts #7734

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bilyana-gospodinova
Copy link
Contributor

Description:
This PR adds the first part of the in-equivalence tests for the internal calls to system accounts. Part of the tests are commented because they are currently failing. Awaiting for the fixes in the consensus and the mirror nodes before uncommenting them.

Fixes #7193

@bilyana-gospodinova bilyana-gospodinova added test Test infrastructure, automated tests required, etc web3 Area: Web3 API limechain Work planned for the LimeChain team labels Feb 13, 2024
@bilyana-gospodinova bilyana-gospodinova self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (136fd96) 92.27% compared to head (8a400d1) 92.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7734   +/-   ##
=========================================
  Coverage     92.27%   92.27%           
  Complexity     6918     6918           
=========================================
  Files           864      864           
  Lines         28332    28332           
  Branches       3363     3363           
=========================================
  Hits          26142    26142           
  Misses         1426     1426           
  Partials        764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch from 6528455 to 5a561f7 Compare February 15, 2024 13:00
@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch from 8a400d1 to a10e213 Compare March 8, 2024 15:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (e4a28be) to head (b2618d6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7734      +/-   ##
============================================
- Coverage     92.41%   89.69%   -2.72%     
+ Complexity     7038     4526    -2512     
============================================
  Files           871      622     -249     
  Lines         28700    20404    -8296     
  Branches       3433     2530     -903     
============================================
- Hits          26522    18302    -8220     
- Misses         1411     1495      +84     
+ Partials        767      607     -160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch 3 times, most recently from 2e9648f to e700c89 Compare March 14, 2024 14:57
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 7193-add-in-equivalence-tests-for-system-accounts branch from e700c89 to b2618d6 Compare March 14, 2024 15:04
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
limechain Work planned for the LimeChain team test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in-equivalence tests
2 participants