Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthereumTransaction acceptance tests #7655

Open
steven-sheehy opened this issue Jan 31, 2024 · 0 comments · May be fixed by #8123
Open

EthereumTransaction acceptance tests #7655

steven-sheehy opened this issue Jan 31, 2024 · 0 comments · May be fixed by #8123
Assignees
@JivkoKelchev @vtronkov
Labels
enhancement Type: New feature limechain Work planned for the LimeChain team test Test infrastructure, automated tests required, etc
Milestone
0.106.0

Comments

@steven-sheehy
Copy link
Member

Problem

Acceptance tests are lacking coverage for EthereumTransaction.

Solution

We already create a lot of contracts and execute contract calls against HAPI in scenarios where we're not really testing those transactions. We should just replace a few of those with an ethereumtransaction that does it. We should test one each of the 3 possible types:

  • Legacy
  • EIP-2930
  • EIP-1559

Alternatives

No response
@steven-sheehy steven-sheehy added enhancement Type: New feature test Test infrastructure, automated tests required, etc labels Jan 31, 2024
@IvanKavaldzhiev IvanKavaldzhiev mentioned this issue Mar 8, 2024
Open
@yosiftouma yosiftouma added the limechain Work planned for the LimeChain team label Apr 4, 2024
@vtronkov vtronkov self-assigned this Apr 4, 2024
@JivkoKelchev JivkoKelchev linked a pull request Apr 18, 2024 that will close this issue
Open
@vtronkov vtronkov mentioned this issue Apr 23, 2024
Open
@steven-sheehy steven-sheehy added this to the 0.105.0 milestone May 3, 2024
@steven-sheehy steven-sheehy modified the milestones: 0.105.0, 0.106.0 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JivkoKelchev JivkoKelchev

@vtronkov vtronkov

Labels
enhancement Type: New feature limechain Work planned for the LimeChain team test Test infrastructure, automated tests required, etc
Projects
Mirror Node
Status: 👀 In review
Smart Contract Sprint Board
Status: In Review
Milestone
0.106.0
Development

Successfully merging a pull request may close this issue.

EthereumTransaction acceptance tests hashgraph/hedera-mirror-node
4 participants
@steven-sheehy @JivkoKelchev @vtronkov @yosiftouma