Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum call tests cases enhancement #11975

Open
IvanKavaldzhiev opened this issue Mar 8, 2024 · 0 comments
Open

Ethereum call tests cases enhancement #11975

IvanKavaldzhiev opened this issue Mar 8, 2024 · 0 comments
Assignees
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Limechain Work planned for the LimeChain team Work Package Limechain Work package

Comments

@IvanKavaldzhiev
Copy link
Collaborator

IvanKavaldzhiev commented Mar 8, 2024

Problem

We need to extend acceptance tests in mirror node to send calls from ethereum type, so that we cover more test cases in these scenarios and validate that proper sidecars are exported.

Additionally we already observed some issue with ethereum transactions and the sidecars that are exported that should be analyzed and fixed.

Test cases for some ethereum transactions corner cases could be added in test-clients to ensure code quality.

Solution

We need to fix existing ethereum transaction type issues and add more test cases for them. This includes also extending acceptance test capabilities in mirror-node.

Tasks

  1. Add capability of sending ethereum transactions via acceptance tests -> EthereumTransaction acceptance tests hedera-mirror-node#7655
  2. EthereumTransaction has top level contract action with zero gasUsed #11948
  3. Function result for EthereumTransaction has functionParameters without selector #11947
  4. EthereumTransaction wrapping contract create does not have contractbytecode sidecar #11946
  5. contractCalls to etheretumContractCalls NPE #12012
  6. Add more tests in test-clients for covering corner cases for Ethereum transactions (including tests for gasConsumed field) #12627
  7. Add gasConsumed cases for Ethereum transactions #12948
  8. Use web3j in acceptance tests hedera-mirror-node#8392

Security Implications

None

References/Dependencies

@IvanKavaldzhiev IvanKavaldzhiev added Bug An error that causes the feature to behave differently than what was expected based on design. Limechain Work planned for the LimeChain team Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Work Package Limechain Work package labels Mar 8, 2024
@vtronkov vtronkov self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Limechain Work planned for the LimeChain team Work Package Limechain Work package
Projects
Status: In Review
Development

No branches or pull requests

3 participants