fix: unit tests failing in CI #2258

konstantinabl · 2024-03-28T14:46:17Z

Description:

This PR updates the precheck.spec.ts file to resolve a TypeError occurring in the ethers package when using node version 20. The error arises because the 'from' field in the transaction doesn't match the signer's address.
It also adds return types and JSDoc where missing.

Related issue(s):

Fixes #2223

Notes for reviewer:

Checklist

Tested (unit, integration, etc.)

github-actions · 2024-03-28T14:51:11Z

Tests

    2 files 148 suites 13s ⏱️
821 tests 820 ✔️ 1 💤 0 ❌
833 runs 832 ✔️ 1 💤 0 ❌

Results for commit 2d54d8f.

♻️ This comment has been updated with latest results.

codecov-commenter · 2024-03-28T14:53:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (8c061f1) to head (20b1ac6).

❗ Current head 20b1ac6 differs from pull request most recent head dbe47ce. Consider uploading reports for the commit dbe47ce to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines         644      644           
  Branches      118      118           
=======================================
  Hits          484      484           
  Misses        115      115           
  Partials       45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-29T09:44:26Z

Acceptance Tests

    21 files   336 suites 26m 14s ⏱️
  587 tests   577 ✔️   3 💤   7 ❌
1 191 runs 1 167 ✔️ 13 💤 11 ❌

Results for commit 2d54d8f.

♻️ This comment has been updated with latest results.

natanasow

LGTM 👏

packages/relay/src/lib/precheck.ts

wiz-inc-8f76296f7c · 2024-04-03T21:05:28Z

Wiz Scan Summary


IaC Misconfigurations
Vulnerabilities
Sensitive Data
Total
Secrets

AlfredoG87

LGTM

natanasow

LGTM, 2 nits

packages/relay/src/lib/precheck.ts

victor-yanev · 2024-04-24T13:19:09Z

packages/relay/tests/lib/precheck.spec.ts

-      evm_address: mockData.accountEvmAddress,
-      ethereum_nonce: defaultNonce,
-    };
+    let defaultNonce, defaultTx, signed, parsedTx, mirrorAccount, wallet;


QQ: Why did we change these from const to let?

Also, please specify the expected type of the variable if we're going to use let.

Some of them are let cause they are used in the tests below

Should I set mirror account to type any?

It's better now, thanks! I would only move each field to a separate line and change the defaultNonce to const (it's not changed anywhere I believe?).

georgi-l95

LG, small nit

packages/relay/tests/lib/eth/eth-helpers.ts

Nana-EC

LG.
Might need to rebase

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

sonarcloud · 2024-05-16T10:51:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

konstantinabl linked an issue Mar 28, 2024 that may be closed by this pull request

Unit tests failing in CI #2223

Open

konstantinabl force-pushed the 2223-unit-tests-failing-in-ci branch from aadb3fa to bf34483 Compare March 28, 2024 14:54

konstantinabl requested review from Ivo-Yankov, georgi-l95, natanasow and victor-yanev March 28, 2024 15:13

konstantinabl marked this pull request as ready for review March 29, 2024 13:46

konstantinabl requested review from AlfredoG87, ebadiere, lukelee-sl and a team as code owners March 29, 2024 13:46

Ivo-Yankov previously approved these changes Mar 29, 2024

View reviewed changes

natanasow previously approved these changes Mar 29, 2024

View reviewed changes

packages/relay/src/lib/precheck.ts Outdated Show resolved Hide resolved

packages/relay/src/lib/precheck.ts Outdated Show resolved Hide resolved

georgi-l95 dismissed stale reviews from natanasow and Ivo-Yankov via b4f1c6c April 3, 2024 11:24

georgi-l95 force-pushed the 2223-unit-tests-failing-in-ci branch from 0a995bc to d185259 Compare April 3, 2024 11:26

AlfredoG87 previously approved these changes Apr 3, 2024

View reviewed changes

georgi-l95 dismissed AlfredoG87’s stale review via 159eeca April 3, 2024 21:31

AlfredoG87 previously approved these changes Apr 3, 2024

View reviewed changes

georgi-l95 dismissed AlfredoG87’s stale review via 6296a49 April 3, 2024 21:43

georgi-l95 force-pushed the 2223-unit-tests-failing-in-ci branch from 387e005 to dbe47ce Compare April 4, 2024 17:44

konstantinabl force-pushed the 2223-unit-tests-failing-in-ci branch from dbe47ce to 7374fc8 Compare April 24, 2024 08:44

konstantinabl requested review from Ivo-Yankov, natanasow and AlfredoG87 April 24, 2024 12:49

natanasow previously approved these changes Apr 24, 2024

View reviewed changes

packages/relay/src/lib/precheck.ts Outdated Show resolved Hide resolved

packages/relay/src/lib/precheck.ts Outdated Show resolved Hide resolved

victor-yanev requested changes Apr 24, 2024

View reviewed changes

konstantinabl dismissed natanasow’s stale review via be88a86 April 24, 2024 14:52

konstantinabl force-pushed the 2223-unit-tests-failing-in-ci branch from be88a86 to dd3a998 Compare April 25, 2024 07:06

konstantinabl requested review from victor-yanev and natanasow April 25, 2024 07:07

konstantinabl force-pushed the 2223-unit-tests-failing-in-ci branch from dd3a998 to cf60f06 Compare April 25, 2024 07:29

victor-yanev previously approved these changes Apr 25, 2024

View reviewed changes

konstantinabl dismissed victor-yanev’s stale review via e9e5a89 April 26, 2024 07:06

konstantinabl requested a review from victor-yanev April 26, 2024 07:15

victor-yanev previously approved these changes Apr 26, 2024

View reviewed changes

georgi-l95 previously approved these changes Apr 27, 2024

View reviewed changes

packages/relay/tests/lib/eth/eth-helpers.ts Show resolved Hide resolved

konstantinabl dismissed stale reviews from georgi-l95 and victor-yanev via ef6eb8c April 29, 2024 07:51

konstantinabl requested review from georgi-l95 and victor-yanev April 29, 2024 07:51

Nana-EC previously approved these changes May 7, 2024

View reviewed changes

konstantinabl added 7 commits May 16, 2024 13:50

Fixes tests that were not being executed due to error

6aecac2

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Fixes formatting

381f68e

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Refactors default transaction

bddba5a

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Refactors precheck; adds JSDoc; removes unecessary let etc.

9e1745d

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Removes console.log

2b736a5

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Addresses PR comments

de73613

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Improves variable check

2d54d8f

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl dismissed Nana-EC’s stale review via 2d54d8f May 16, 2024 10:50

konstantinabl force-pushed the 2223-unit-tests-failing-in-ci branch from ef6eb8c to 2d54d8f Compare May 16, 2024 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unit tests failing in CI #2258

fix: unit tests failing in CI #2258

konstantinabl commented Mar 28, 2024 •

edited

github-actions bot commented Mar 28, 2024 •

edited

codecov-commenter commented Mar 28, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited

natanasow left a comment

wiz-inc-8f76296f7c bot commented Apr 3, 2024 •

edited

AlfredoG87 left a comment

natanasow left a comment

victor-yanev Apr 24, 2024

konstantinabl Apr 24, 2024

konstantinabl Apr 24, 2024

victor-yanev Apr 25, 2024

georgi-l95 left a comment

Nana-EC left a comment

sonarcloud bot commented May 16, 2024

fix: unit tests failing in CI #2258

Are you sure you want to change the base?

fix: unit tests failing in CI #2258

Conversation

konstantinabl commented Mar 28, 2024 • edited

github-actions bot commented Mar 28, 2024 • edited

Tests

codecov-commenter commented Mar 28, 2024 • edited

Codecov Report

github-actions bot commented Mar 29, 2024 • edited

Acceptance Tests

natanasow left a comment

Choose a reason for hiding this comment

wiz-inc-8f76296f7c bot commented Apr 3, 2024 • edited

Wiz Scan Summary

AlfredoG87 left a comment

Choose a reason for hiding this comment

natanasow left a comment

Choose a reason for hiding this comment

victor-yanev Apr 24, 2024

Choose a reason for hiding this comment

konstantinabl Apr 24, 2024

Choose a reason for hiding this comment

konstantinabl Apr 24, 2024

Choose a reason for hiding this comment

victor-yanev Apr 25, 2024

Choose a reason for hiding this comment

georgi-l95 left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 16, 2024

Quality Gate passed

konstantinabl commented Mar 28, 2024 •

edited

github-actions bot commented Mar 28, 2024 •

edited

codecov-commenter commented Mar 28, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited

wiz-inc-8f76296f7c bot commented Apr 3, 2024 •

edited