Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Using node-memwatch to find a memory leak #2253

Closed
wants to merge 2 commits into from

Conversation

AlfredoG87
Copy link
Collaborator

@AlfredoG87 AlfredoG87 commented Mar 27, 2024

Description:

Related issue(s):

Fixes #

Notes for reviewer:

image

image

 "before": {
    "nodes": 402031,
    "size_bytes": 53270671,
    "size": "50.8 mb"
  },
  "after": {
    "nodes": 404005,
    "size_bytes": 53444686,
    "size": "50.97 mb"
  },
  "change": {
    "size_bytes": 174015,
    "size": "169.94 kb",
    "freed_nodes": 1174,
    "allocated_nodes": 3148,
    "details": [
      {
        "what": "AbortController",
        "size_bytes": 32,
        "size": "32 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Arguments",
        "size_bytes": -80,
        "size": "-80 bytes",
        "+": 0,
        "-": 2
      },
      {
        "what": "Array",
        "size_bytes": 12352,
        "size": "12.06 kb",
        "+": 95,
        "-": 20
      },
      {
        "what": "ArrayBuffer",
        "size_bytes": 240,
        "size": "240 bytes",
        "+": 3,
        "-": 0
      },
      {
        "what": "AxiosError",
        "size_bytes": 24,
        "size": "24 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "AxiosHeaders",
        "size_bytes": 208,
        "size": "208 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "BufferList",
        "size_bytes": 96,
        "size": "96 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "ClientRequest",
        "size_bytes": 464,
        "size": "464 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Closure",
        "size_bytes": 3120,
        "size": "3.05 kb",
        "+": 57,
        "-": 4
      },
      {
        "what": "Code",
        "size_bytes": 102696,
        "size": "100.29 kb",
        "+": 1909,
        "-": 857
      },
      {
        "what": "DOMException",
        "size_bytes": 24,
        "size": "24 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "EventEmitter",
        "size_bytes": 104,
        "size": "104 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "EventTarget",
        "size_bytes": 24,
        "size": "24 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Generator",
        "size_bytes": 184,
        "size": "184 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "Immediate",
        "size_bytes": 88,
        "size": "88 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "IncomingMessage",
        "size_bytes": 256,
        "size": "256 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Log",
        "size_bytes": -192,
        "size": "-192 bytes",
        "+": 0,
        "-": 2
      },
      {
        "what": "Map",
        "size_bytes": 32,
        "size": "32 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Native",
        "size_bytes": 44896,
        "size": "43.84 kb",
        "+": 109,
        "-": 28
      },
      {
        "what": "Number",
        "size_bytes": 240,
        "size": "240 bytes",
        "+": 16,
        "-": 1
      },
      {
        "what": "Object",
        "size_bytes": 1824,
        "size": "1.78 kb",
        "+": 43,
        "-": 3
      },
      {
        "what": "Promise",
        "size_bytes": 432,
        "size": "432 bytes",
        "+": 9,
        "-": 0
      },
      {
        "what": "ReadableState",
        "size_bytes": 528,
        "size": "528 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "RedirectableRequest",
        "size_bytes": 152,
        "size": "152 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "SecureContext",
        "size_bytes": 136,
        "size": "136 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "Set",
        "size_bytes": 32,
        "size": "32 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "String",
        "size_bytes": 11320,
        "size": "11.05 kb",
        "+": 275,
        "-": 14
      },
      {
        "what": "TCP",
        "size_bytes": 56,
        "size": "56 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "TLSSocket",
        "size_bytes": 552,
        "size": "552 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "TLSWrap",
        "size_bytes": 56,
        "size": "56 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Timeout",
        "size_bytes": 120,
        "size": "120 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "TimersList",
        "size_bytes": 72,
        "size": "72 bytes",
        "+": 1,
        "-": 0
      },
      {
        "what": "Uint8Array",
        "size_bytes": 192,
        "size": "192 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "WritableState",
        "size_bytes": 576,
        "size": "576 bytes",
        "+": 2,
        "-": 0
      },
      {
        "what": "system / Context",
        "size_bytes": 1408,
        "size": "1.38 kb",
        "+": 22,
        "-": 1
      }
    ]
  }
}

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 changed the title Using node-memwatch to find a memory leak DO NOT MERGE: Using node-memwatch to find a memory leak Mar 27, 2024
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant