Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface for Redis and LRU cache (ICacheClient) has void return types instead of Promise<void> #2387

Open
konstantinabl opened this issue Apr 23, 2024 · 0 comments · May be fixed by #2410
Open

Interface for Redis and LRU cache (ICacheClient) has void return types instead of Promise<void> #2387

konstantinabl opened this issue Apr 23, 2024 · 0 comments · May be fixed by #2410
Assignees
@konstantinabl
Labels
bug Something isn't working limechain

Comments

@konstantinabl
Copy link
Collaborator

Description

Currently, both RedisCache and LRU cache implement the ICacheClient interface, which has return type void on all its methods, although the RedisCache has asynchronous methods. The interface has to be adjusted as well as the LRU cache, which will have to return Promises as well, since it makes sense for both classes to be aligned.

Steps to reproduce

Open ICacheClient.ts

Additional context

No response

Hedera network

other

Version

v0.46.0

Operating system

None
@konstantinabl konstantinabl added the bug Something isn't working label Apr 23, 2024
@konstantinabl konstantinabl mentioned this issue Apr 23, 2024
Merged
2 tasks
@konstantinabl konstantinabl self-assigned this Apr 23, 2024
@konstantinabl konstantinabl linked a pull request Apr 25, 2024 that will close this issue
Makes ICacheClient return type promise and changes LRUCache accordingly #2410
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konstantinabl konstantinabl

Labels
bug Something isn't working limechain
Projects
Smart Contract Sprint Board
Status: Tasks In Progress
Milestone
No milestone
1 participant
@konstantinabl