New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.0: Backend and Front-end refactoring, UI revamp #6
Conversation
See #6 for details
cc0c5e4
to
c6537d3
Compare
gpt-3.5 series models can also be used in that context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a huge PR!
Looks good to me. I read everything through and did not spot anything; I did not try running it locally.
I left a couple very tiny suggestions, all of which can certainly be ignored.
Re: the new UI, I'll note that the streaming text and auto-scrolling is a bit too much motion for me personally... it might be nice to have an option that let a user toggle that off for a steadier experience, maybe off if the user prefers-reduced-motion
? But that sounds like something that could be tacked on later; I'm not suggesting it block this PR!!
- Added support for prefers-reduced-motion (no auto scroll) - Updated "Enforce singleton" pattern - Put trace logs in logger.debug calls - Updated instructions of OPENAI_BASE_URL
Thank you so much for having a look @rebeccacremona!
Definitely worth doing: I added logic to disable auto-scroll when |
This PR is a candidate for a v0.1.0 of WARC-GPT, which now looks like this:
Screen.Recording.2024-03-20.at.5.09.28.PM.mov
It mainly consists in:
A few other things that were added / removed:
Many thanks in advance to @rebeccacremona who will be having a look at this PR 馃槃