Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify --pages option to copy pages files directly into WACZ #92

Merged
merged 6 commits into from Mar 22, 2024
Merged

Modify --pages option to copy pages files directly into WACZ #92

merged 6 commits into from Mar 22, 2024

Commits on Mar 20, 2024

  1. Add --pagesDir option to copy pages files directly into WACZ 

    pages.jsonl and extraPages.jsonl files will be copied, other files
are ignored.
    @tw4l
    tw4l committed Mar 20, 2024
    Copy the full SHA
    216c464 View commit details
    Browse the repository at this point in the history

  2. Fix linting

    @tw4l
    tw4l committed Mar 20, 2024
    Copy the full SHA
    6a61f72 View commit details
    Browse the repository at this point in the history

  3. Fix help text typo

    @tw4l
    tw4l committed Mar 20, 2024
    Copy the full SHA
    d8ba5f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Make code review revisions 

    - Replace existing -p/--pages implementation rather than adding
another option
- Rather than hardcoding allowed names, check that JSONL files
passed have correct extension and are well-formed JSON lines
- Modify tests and fixtures to account for new logic
    @tw4l
    tw4l committed Mar 21, 2024
    Copy the full SHA
    02ef17a View commit details
    Browse the repository at this point in the history

  2. Check conformance of pages files against spec

    @tw4l
    tw4l committed Mar 21, 2024
    Copy the full SHA
    dd847e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Add trace logging for error when pages aren't validated 

    Co-authored-by: Matteo Cargnelutti <matteo.cargnelutti@gmail.com>
    @tw4l @matteocargnelutti
    tw4l and matteocargnelutti committed Mar 22, 2024
    Copy the full SHA
    729affa View commit details
    Browse the repository at this point in the history