Copyediting #90
Merged
Copyediting #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ js-wacz create --file "collection/*.warc" | |||
|
|
|||
| ### --output, -o | |||
|
|
|||
| Allows to specify where the resulting `.wacz` file should be created, and what its filename should be. | |||
| Specify where the resulting `.wacz` file should be created, and what its filename should be. | |||
There was a problem hiding this comment.
My brain wants to use "Specifies" and I am not sure why 🤔 . What do you think @bensteinberg ?
There was a problem hiding this comment.
I could see it either way. There could be an implicit "This option": "(This option) Specifies" -- or an implicit "This option allows you to" or "With this option you can": "(This option allows you to) Specify".
There was a problem hiding this comment.
I think I incline toward the latter in the interest of saving precious characters ;) but I'm happy to change these.
There was a problem hiding this comment.
Nope, that makes sense to me, let's ship it :D ! thanks again
matteocargnelutti
approved these changes
Mar 11, 2024
|
Thank you @bensteinberg ! I left a question but this is much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a few instances of the phrase "allows to".