Add option to use existing CDXJ rather than indexing from WARCs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/cli.js
Outdated
|
|
||
| const ext = cdxjFile.split('.').pop() | ||
| if (!allowedExts.includes(ext)) { | ||
| log.info(`CDXJ: Skipping file ${cdxjFile}, not a CDXJ file`) |
There was a problem hiding this comment.
@tw4l Nitpick: I'd make that a warning maybe?
There was a problem hiding this comment.
Good call, just pushed the change :)
matteocargnelutti
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
This is perfect @tw4l - Thank you very much for a great PR.
I can merge and publish whenever you're ready :)
Thanks so much @matteocargnelutti ! Should be ready now :) |
matteocargnelutti
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
All tests and linting are passing, please let me know if you'd like to see any changes!
Since not indexing from WARCs means losing another way to detect pages, the new
--cdxjoption must be used in combination with--pages, and I've added a validator to fail early if this is not the case.