Allow multiple json messages per TCP stream #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHeelin
force-pushed
the
JsonDecoder
branch
from
d0eaf3b
to
5f764ca
Compare
Assumes one json message per line
RichardHeelin
force-pushed
the
JsonDecoder
branch
from
5f764ca
to
5a2bee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to use TCP to stream all our log messages in one connection to reduce the overhead on our application, however protologbeat only handles the first message by default. By wrapping the
Unmarshalcall in abufio.Scannerwe can parse one json message per line, allowing for an unlimited number of logs to be sent in one TCP stream.This should also resolve issue #15, assuming they want to use json as the message format.