Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [PIPE-18794]: optimise the ExpressionInput component #1311

Merged
merged 2 commits into from
May 15, 2024

Conversation

PratyushGar
Copy link
Contributor

@PratyushGar PratyushGar commented May 14, 2024

Changes and their impact:

  1. Moving JSX of Popover Second Child to JSX Block:
    Earlier the JSX for the dropdown was being created and rendered every time the renderer function was called, moving this into a separate JSX block () will now render when needed ( popover opened) to avoid creation and rendering of the dropdown when the popover is closed
  2. Using useMemo for filteredItems:
    For large items array, the react state is recalculated every time the queryValue or items prop is changed, moving them to useMemo ensures that the filtering operation is only performed when necessary.

image

JIRA: PIPE-19058

You can use the following comments to re-trigger PR Checks

  • Jest: retrigger jest
  • Prettier: retrigger prettier
  • Type Check: retrigger typecheck
  • ESLint: retrigger eslint
  • StyleLint: retrigger stylelint
  • Build: retrigger build
  • Title Check: retrigger titlecheck
  • ImageSnapshot retrigger ImageSnapshot

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2479

@bot2-harness
Copy link

Image snapshots failed please check https://console.cloud.google.com/storage/browser/ui-team-bucket/uicore-2480

@PratyushGar PratyushGar merged commit d67201c into main May 15, 2024
7 of 8 checks passed
@PratyushGar PratyushGar deleted the chore/PIPE-18794 branch May 15, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants