chore: [PIPE-18794]: optimise the ExpressionInput component #1311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes and their impact:
Earlier the JSX for the dropdown was being created and rendered every time the renderer function was called, moving this into a separate JSX block () will now render when needed ( popover opened) to avoid creation and rendering of the dropdown when the popover is closed
For large
items
array, the react state is recalculated every time the queryValue or items prop is changed, moving them to useMemo ensures that the filtering operation is only performed when necessary.JIRA: PIPE-19058
You can use the following comments to re-trigger PR Checks
retrigger jest
retrigger prettier
retrigger typecheck
retrigger eslint
retrigger stylelint
retrigger build
retrigger titlecheck
retrigger ImageSnapshot