Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: [CI-12466]: Initialize optimizationState to empty string #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anurag-harness
Copy link
Contributor

optimizationState should be initialized to an empty string and should only contain a non empty value if the FF to get optimization state is enabled. This will ensure backward compatibility of a vm runner with an older delegate

Copy link
Contributor

@rutvijmehta-harness rutvijmehta-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anurag-harness why is this change required? The empty string will still be part of the JSON. Backward compatibility is taken care of by ignoreUnknown annotation.

If the delegate is very old, we don't guarantee backward compatibility anyway. Please check with delegate team the number of releases after which backward compatibility is not supported/guaranteed.

@anurag-harness
Copy link
Contributor Author

@anurag-harness why is this change required? The empty string will still be part of the JSON. Backward compatibility is taken care of by ignoreUnknown annotation.

If the delegate is very old, we don't guarantee backward compatibility anyway. Please check with delegate team the number of releases after which backward compatibility is not supported/guaranteed.

@rutvijmehta-harness Due to the omitempty in the structure, the field will be omitted if it is an empty string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants