Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CDS-89581]: Incorrect yaml generated for failure strategy #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayushitiwari024
Copy link

@ayushitiwari024 ayushitiwari024 commented Mar 27, 2024

Issue: RetryInterval is not marked as a mandatory field which throws up an error later during plan creation.

fix: Added a schema validation to mark retryCount, retryIntervals and Post retry strategies as mandatory fields

Testing:

  1. Passed an empty array in retryIntervals
image
  1. Passed an empty string in an array of retryIntervals
image 3. Passed empty string as an array image 4. Passed an empty array all together image image 5. removed post retry failure strategies image 6. Didn't provide retryIntervals image 7. Didn't provide retryCounts image image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants