Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use raw string (...) with regexp.MustCompile #3358

Open
wants to merge 1 commit into
base: drone
Choose a base branch
from

Conversation

testwill
Copy link

@testwill testwill commented Sep 1, 2023

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

  • Commit is a single logical unit of work, only use multiple commits if doing different tasks
  • Commit does not include commented out code or unneeded files
  • rebase of main branch

The Content

  • Must include testing for bug or feature
  • Must include appropriate documentation changes if it is introducing a new feature or changing existing functionality
  • Must pass existing test suites

The Commit Message

  • Short meaningful description (ex: remove deprecated steps)
  • Uses the imperative, present tense: "change", not "changed" or "changes"
  • Includes motivation for the change, and contrasts its implementation with the previous behavior

The Pull Request

  • What is the reason for this change
  • Example usage of the failure for a bug, or configuration and expected output for a feature
  • Steps to test the change

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hitesharinga hitesharinga changed the base branch from master to drone October 4, 2023 02:41
@bot-harness
Copy link
Contributor

This PR has been automatically closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants