Skip to content

Commit

Permalink
Fix broken sticky header in PR page due to library upgrade (#1236)
Browse files Browse the repository at this point in the history
  • Loading branch information
tan-nhu authored and Harness committed Apr 19, 2024
1 parent 2d96ca5 commit e45dcf3
Show file tree
Hide file tree
Showing 20 changed files with 34 additions and 32 deletions.
2 changes: 1 addition & 1 deletion web/src/App.module.scss
Expand Up @@ -31,7 +31,7 @@
height: 70vh !important;
}

.PageBody--pageBody {
[class*='PageBody--pageBody'] {
min-height: calc(var(--page-height) - var(--page-header-height, 64px));
overflow: visible;
}
Expand Down
Expand Up @@ -138,7 +138,7 @@
}

.checkboxLabel {
:global(.Tooltip--acenter) {
:global([class*='Tooltip--acenter']) {
font-size: 14px;
font-style: normal;
font-weight: 600;
Expand Down
Expand Up @@ -86,12 +86,13 @@

.hideButtonIcon {
:global {
.ConfirmationDialog--header {
[class*='ConfirmationDialog--header'] {
.bp3-icon {
display: none !important;
}
}
.ConfirmationDialog--body {

[class*='ConfirmationDialog--body'] {
padding-left: 3px !important;
}
}
Expand Down
Expand Up @@ -45,7 +45,8 @@
margin-left: var(--spacing-small) !important;
}
}
:global(.StyledProps--font-variation-h4) {

:global([class*='StyledProps--font-variation-h4']) {
margin-top: unset !important;
}
}
Expand Down
Expand Up @@ -23,7 +23,7 @@
width: 100px !important;
min-width: 103px !important;

.Select--menuItem {
[class*='Select--menuItem'] {
width: 100px !important;
}
}
Expand Down
8 changes: 4 additions & 4 deletions web/src/components/ImageCarousel/ImageCarousel.module.scss
Expand Up @@ -50,13 +50,13 @@
}
}

.Dialog--children,
.Carousel--carouselItem {
[class*='Dialog--children'],
[class*='Carousel--carouselItem'] {
justify-content: center !important;
align-items: center;
}

.Dialog--close {
[class*='Dialog--close'] {
fill: var(--primary-bg) !important;
--intent-color: var(--primary-bg) !important;
position: absolute !important;
Expand All @@ -71,7 +71,7 @@
right: 0.75%;

:global {
.Button--variation.Button--variation-tertiary {
[class*='Button--variation'][class*='Button--variation-tertiary'] {
--background-color: unset !important;
.bp3-icon {
padding-right: unset !important;
Expand Down
Expand Up @@ -43,7 +43,7 @@
.bp3-form-helper-text {
margin-top: unset !important;
}
.FormError--errorDiv {
[class*='FormError--errorDiv'] {
display: none !important;
}
}
Expand Down
Expand Up @@ -30,7 +30,7 @@
min-width: 214px;
}

.menuItem {
[class*='menuItem'] {
max-width: fit-content;
}
}
Expand Down Expand Up @@ -125,7 +125,7 @@

.checkbox {
:global {
.Tooltip--acenter {
[class*='Tooltip--acenter'] {
opacity: 0.7 !important;
}
.bp3-control-indicator {
Expand Down Expand Up @@ -163,7 +163,7 @@
.bp3-form-helper-text {
margin-top: unset !important;
}
.FormError--errorDiv {
[class*='FormError--errorDiv'] {
display: none !important;
}
}
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/PluginsPanel/PluginsPanel.module.scss
Expand Up @@ -40,7 +40,7 @@
height: calc(100% - var(--spacing-large) - var(--spacing-xxlarge));
width: 100%;
:global {
.FormikForm--main {
[class*='FormikForm--main'] {
height: 100%;
& > div {
height: 100%;
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/Home/Home.module.scss
Expand Up @@ -37,7 +37,7 @@

.bigButton {
:global {
.SplitButton--splitButton {
[class*='SplitButton--splitButton'] {
> .bp3-button {
.bp3-button-text {
font-size: 16px !important;
Expand Down
Expand Up @@ -112,7 +112,7 @@
}

:global {
.TableV2--header {
[class*='TableV2--header'] {
border-bottom: 1px solid var(--grey-100) !important;
padding-top: var(--spacing-small) !important;
padding-left: var(--spacing-medium) !important;
Expand All @@ -128,7 +128,7 @@

.ownerContainer {
:global {
.Avatar--Avatar {
[class*='Avatar--Avatar'] {
cursor: unset !important;
&:first-child {
margin-left: unset !important;
Expand Down
Expand Up @@ -61,10 +61,10 @@
padding: var(--spacing-xlarge) var(--spacing-xlarge) 0 var(--spacing-xlarge) !important;

:global {
.TableV2--row {
[class*='TableV2--row'] {
height: 45px !important;
}
.TableV2--row:last-child {
[class*='TableV2--row']:last-child {
border-bottom-left-radius: 4px !important;
}
}
Expand Down
Expand Up @@ -19,7 +19,7 @@

.table {
background-color: var(--white) !important;
:global(.TableV2--row:last-child) {
:global([class*='TableV2--row']:last-child) {
border-bottom-left-radius: 4px !important;
border-bottom-right-radius: 4px !important;
}
Expand Down Expand Up @@ -104,7 +104,7 @@
.commitContainer {
:global {
.bp3-popover-target {
.StyledProps--font {
[class*='StyledProps--font'] {
color: var(--grey-600) !important;
}
}
Expand Down
Expand Up @@ -91,7 +91,7 @@
}

.radioContainer {
:global(.RadioButton--radio) {
:global([class*='RadioButton--radio']) {
display: flex;
align-items: center;
}
Expand Down Expand Up @@ -139,7 +139,7 @@
}

.editContainer {
:global(.TextInput--main) {
:global([class*='TextInput--main']) {
margin-bottom: unset !important;
font-size: 20px;
}
Expand Down
Expand Up @@ -38,7 +38,7 @@

.radioContainer {
margin-top: var(--spacing-medium) !important;
:global(.RadioButton--radio) {
:global([class*='RadioButton--radio']) {
display: flex;
flex-direction: row !important;
align-items: center;
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/Search/Search.module.scss
Expand Up @@ -249,7 +249,7 @@
}

.noResultContainer {
:global(.NoDataCard--message) {
:global([class*='NoDataCard--message']) {
display: none !important;
}
}
Expand Down
Expand Up @@ -28,7 +28,7 @@
}

.tableContainer {
:global(.TableV2--card) {
:global([class*='TableV2--card']) {
box-shadow: 0px 0.5px 2px 0px rgba(96, 97, 112, 0.16), 0px 0px 1px 0px rgba(40, 41, 61, 0.08);
}
}
4 changes: 2 additions & 2 deletions web/src/pages/SpaceSettings/SpaceSettings.module.scss
Expand Up @@ -148,7 +148,7 @@

.checkbox {
:global {
.Tooltip--acenter {
[class*='Tooltip--acenter'] {
opacity: 0.7 !important;
}
.bp3-control-indicator {
Expand Down Expand Up @@ -200,7 +200,7 @@
.bp3-form-helper-text {
margin-top: unset !important;
}
.FormError--errorDiv {
[class*='FormError--errorDiv'] {
display: none !important;
}
}
Expand Down
4 changes: 2 additions & 2 deletions web/src/pages/UserProfile/UserProfile.module.scss
Expand Up @@ -27,7 +27,7 @@
box-shadow: 0px 0.5px 2px 0px rgba(96, 97, 112, 0.16), 0px 0px 1px 0px rgba(40, 41, 61, 0.08);

:global {
.TableV2--row {
[class*='TableV2--row'] {
padding: var(--spacing-4) var(--spacing-medium);
}
}
Expand All @@ -40,7 +40,7 @@
min-height: 186px;

:global {
.TextInput--main {
[class*='TextInput--main'] {
margin-bottom: 0 !important;
}
}
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/WebhookNew/WehookForm.module.scss
Expand Up @@ -37,7 +37,7 @@
margin-top: 20px !important;

:global {
.RadioButton--radio {
[class*='RadioButton--radio'] {
margin-top: 10px;
}
}
Expand Down

0 comments on commit e45dcf3

Please sign in to comment.